Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chain: Use f2 code #4

Merged
merged 27 commits into from
Jul 8, 2019
Merged

chain: Use f2 code #4

merged 27 commits into from
Jul 8, 2019

Conversation

magik6k
Copy link
Contributor

@magik6k magik6k commented Jul 5, 2019 •
edited
Loading

This PR brings most chain related code from f2

Based on #2

State: not building (but close)

Todo:

  • Get this to at least build
    • Don't depend on go-filecoin
      • This makes gomod annoying
      • Extract go-filecoin/bls-signatures
      • Extract go-filecoin/crypto
      • Extract / don't depend on go-filecoin/testhelpers/testflags
  • Review code, make some issues to track todos
  • Fix lint warnings
    • Maybe
  • Start wire everything into the constructor

@whyrusleeping
Copy link
Member

+1 to extracting bls-signatures and /crypto. The address code here is also from go-filecoin. Let's pull that into a separate repo as well

@whyrusleeping
Copy link
Member

Meta note:
It would make me so amazingly happy if we could collapse the blockservice and blockstore interfaces into a single interface that gets used everywhere. I have a lot of hacks around those being separate and its quite annoying.

whyrusleeping
whyrusleeping reviewed Jul 5, 2019
View reviewed changes
chain/buf_bstore.go
bstore "github.com/ipfs/go-ipfs-blockstore"
)

type BufferedBS struct {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is a strong candidate for being a separate package.

whyrusleeping
whyrusleeping reviewed Jul 5, 2019
View reviewed changes
chain/blocksync.go
cbor.RegisterCborType(BSTipSet{})
}

type BlockSyncService struct {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not blocking: Would be good to have this as (at least) a subpackage. Maybe even pull it into a separate repo if we can. We want to try and build things that could be reused by go-filecoin.

whyrusleeping
whyrusleeping reviewed Jul 5, 2019
View reviewed changes
chain/mining.go
sharray "github.com/whyrusleeping/sharray"
)

type Miner struct {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This mining code isnt great. fine to merge it in for now just to get things working, but i think rewriting it from scratch once we understand the problem would be good

magik6k and others added 10 commits July 8, 2019 16:07
@magik6k
Pubsub for blocks/messages
d1eb907
@Kubuxu
Probably fix circle
04f645f 
License: MIT
Signed-off-by: Jakub Sztandera <[email protected]>
@Kubuxu
Hopefully now fix circle
35f0699 
License: MIT
Signed-off-by: Jakub Sztandera <[email protected]>
@Kubuxu
Install bzr
7467086 
License: MIT
Signed-off-by: Jakub Sztandera <[email protected]>
@Kubuxu
Use steps in mod-tidy-check
f47210a 
License: MIT
Signed-off-by: Jakub Sztandera <[email protected]>
@Kubuxu
Install make in lint
177131c 
License: MIT
Signed-off-by: Jakub Sztandera <[email protected]>
@Kubuxu
Switch to circleci image
bf3317c 
License: MIT
Signed-off-by: Jakub Sztandera <[email protected]>
@Kubuxu
Fix missing colon
daa1e48 
License: MIT
Signed-off-by: Jakub Sztandera <[email protected]>
@Kubuxu
Fixup make
f851dd4 
License: MIT
Signed-off-by: Jakub Sztandera <[email protected]>
@Kubuxu
Add blssigs to PHONY
4f277c8 
License: MIT
Signed-off-by: Jakub Sztandera <[email protected]>
@Kubuxu
Fix imports and range reference warnings
4df601e 
License: MIT
Signed-off-by: Jakub Sztandera <[email protected]>
@Kubuxu
Run docstring lint in seprate job
eae1851 
License: MIT
Signed-off-by: Jakub Sztandera <[email protected]>
@Kubuxu
Change regex
c69e241 
License: MIT
Signed-off-by: Jakub Sztandera <[email protected]>
whyrusleeping
whyrusleeping approved these changes Jul 8, 2019
View reviewed changes
Copy link
Member

@whyrusleeping whyrusleeping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sweet, it builds for me. lets do this

@whyrusleeping whyrusleeping merged commit 03227e1 into master Jul 8, 2019
@whyrusleeping whyrusleeping deleted the feat/f2-chain branch July 8, 2019 15:55
@arajasek arajasek mentioned this pull request Mar 19, 2020
Merged
magik6k pushed a commit that referenced this pull request Jul 6, 2020
Merge pull request #4 from filecoin-project/master
49281ef 
merge
magik6k added a commit that referenced this pull request Aug 10, 2020
@magik6k
Merge pull request #4 from filecoin-project/feat/dynamic-worker-address
8fc0fd3 
we should always load worker address from the chain
@adlrocha adlrocha mentioned this pull request Oct 14, 2022
Closed
galargh added a commit that referenced this pull request Jul 10, 2024
@galargh
Merge pull request #4 from galargh/ipdx/release-automation-updates
dcd4500 
fix: ci: update triggers to cover miner
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whyrusleeping whyrusleeping whyrusleeping approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@magik6k @whyrusleeping @Kubuxu