Calculate new actor addresses as per updated spec #1429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arajasek
force-pushed
the
asr/NAA
branch
3 times, most recently
from
27e0730 to
e29793e
Compare
|
Mod tidy pls. |
Kubuxu
approved these changes
Mar 20, 2020
chain/vm/runtime.go
Outdated
| @@ -46,6 +46,7 @@ type Runtime struct { | |||
| internalExecutions []*ExecutionResult | |||
| // the first internal call has a value of 1 for this field | |||
| internalCallCounter int64 | |||
There was a problem hiding this comment.
probably want to remove the internal call counter now, yeah?
|
internal counter removed, and go.sum tidied :) |
Kubuxu
approved these changes
Mar 20, 2020
Kubuxu
pushed a commit
that referenced
this pull request
May 12, 2020
Calculate new actor addresses as per updated spec
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Probably wanna wait on this commit entering master in chain-validation before merging this, but it's good for review.
Implements the change in point #4 here: filecoin-project/specs#894