-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add types for one-value params and returns #1242
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1242 +/- ##
==========================================
- Coverage 90.97% 90.96% -0.02%
==========================================
Files 133 133
Lines 26633 26697 +64
==========================================
+ Hits 24230 24284 +54
- Misses 2403 2413 +10
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great. I would like someone else to check the EVM actors, but thank you.
As an aside, it could be nice to implement a constructor-generating macro like https://jeltef.github.io/derive_more/derive_more/constructor.html so we could token.balance_of(¶ms.address).map(BalanceReturn::new)
. But don't hold up this PR for it, and I would do something simple here rather than add a dependency.
|
||
#[derive(Clone, Debug, PartialEq, Eq, Serialize_tuple, Deserialize_tuple)] | ||
#[serde(transparent)] | ||
pub struct NameReturn { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add an issue in https://github.com/helix-onchain/filecoin to move these types there?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Stebalien could you review just the EVM actors for a second set of eyes please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one fix but the EVM logic otherwise looks correct.
@alexytsu ready for merge? Please do so after rebasing. |
bab3a04
to
86891dc
Compare
#817