Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add types for one-value params and returns #817

Closed
arajasek opened this issue Nov 8, 2022 · 1 comment
Closed

Add types for one-value params and returns #817

arajasek opened this issue Nov 8, 2022 · 1 comment
Assignees
@alexytsu
Labels
cleanup P3
Milestone
Reenginering buil...

Comments

@arajasek
Copy link
Contributor

arajasek commented Nov 8, 2022

We currently inconsistently use the raw value directly (eg. Miner::change_owner_address) vs. having a wrapping struct that's "transparently" serialized (eg. Market::WithdrawBalanceReturn).

We should consistently do the latter. #810 (comment)
@arajasek arajasek added the P3 label Nov 8, 2022
@arajasek
Copy link
Contributor Author

arajasek commented Nov 8, 2022

Adding to the API milestone because this effort is a good time for some cleanup

@arajasek arajasek mentioned this issue Nov 8, 2022
Merged
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Network nv19 Mar 3, 2023
@anorth anorth added the cleanup label Mar 3, 2023
This was referenced Mar 9, 2023
Merged
Closed
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Network nv19 Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexytsu alexytsu

Labels
cleanup P3
Projects
No open projects
Network nv19
Status: ✅ Done
Milestone
Reenginering built-in actors API
Development

No branches or pull requests
3 participants
@anorth @arajasek @alexytsu