Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spin 3 world #2887

Merged
merged 3 commits into from
Oct 16, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions crates/world/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ wasmtime::component::bindgen!({
world host {
include fermyon:spin/host;
include fermyon:spin/[email protected];
include fermyon:spin/[email protected];
}
"#,
path: "../../wit",
Expand Down
6 changes: 3 additions & 3 deletions tests/test-components/components/tcp-sockets/src/lib.rs
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
use bindings::wasi::{
io0_2_0_rc_2023_10_18::poll,
sockets0_2_0_rc_2023_10_18::{
io0_2_0::poll,
sockets0_2_0::{
instance_network,
network::{
ErrorCode, IpAddressFamily, IpSocketAddress, Ipv4SocketAddress, Ipv6SocketAddress,
Expand Down Expand Up @@ -43,7 +43,7 @@ impl Component {

let (rx, tx) = loop {
match client.finish_connect() {
Err(ErrorCode::WouldBlock) => poll::poll_one(&client.subscribe()),
Err(ErrorCode::WouldBlock) => { poll::poll(&[&client.subscribe()]); },
result => break ensure_ok!(result),
}
};
Expand Down
32 changes: 18 additions & 14 deletions tests/test-components/helper/src/lib.rs
Original file line number Diff line number Diff line change
@@ -1,18 +1,18 @@
#[cfg(feature = "define-component")]
pub mod bindings {
wit_bindgen::generate!({
world: "platform-rc20231018",
world: "fermyon:spin/platform@3.0.0",
path: "../../../wit",
runtime_path: "::wit_bindgen::rt"
});
}

#[cfg(feature = "define-component")]
use bindings::wasi::http0_2_0_rc_2023_10_18::types::{
Error, Headers, OutgoingBody, OutgoingResponse, ResponseOutparam,
use bindings::wasi::http0_2_0::types::{
ErrorCode, Fields, OutgoingBody, OutgoingResponse, ResponseOutparam,
};
#[cfg(feature = "define-component")]
use bindings::wasi::io0_2_0_rc_2023_10_18::streams::OutputStream;
use bindings::wasi::io0_2_0::streams::OutputStream;

#[cfg(feature = "define-component")]
#[macro_export]
Expand All @@ -23,15 +23,15 @@ macro_rules! define_component {
// For now, this assumes the crate using this macro has `wit-bindgen` as a dependency
mod bindings {
$crate::wit_bindgen::generate!({
world: "http-trigger-rc20231018",
world: "fermyon:spin/http-trigger@3.0.0",
path: "../../../../wit",
exports: {
"wasi:http/[email protected]-rc-2023-10-18": super::Component
"wasi:http/[email protected]": super::Component
},
});
}

use bindings::exports::wasi::http0_2_0_rc_2023_10_18::incoming_handler::{Guest, IncomingRequest, ResponseOutparam};
use bindings::exports::wasi::http0_2_0::incoming_handler::{Guest, IncomingRequest, ResponseOutparam};
struct $name;

impl Guest for $name {
Expand All @@ -40,7 +40,7 @@ macro_rules! define_component {
}
}

impl From<ResponseOutparam> for $crate::bindings::wasi::http0_2_0_rc_2023_10_18::types::ResponseOutparam {
impl From<ResponseOutparam> for $crate::bindings::wasi::http0_2_0::types::ResponseOutparam {
fn from(value: ResponseOutparam) -> Self {
unsafe { Self::from_handle(value.into_handle()) }
}
Expand All @@ -50,27 +50,31 @@ macro_rules! define_component {

#[cfg(feature = "define-component")]
pub fn handle(response_out: ResponseOutparam, result: Result<(), String>) {
let response = |status| OutgoingResponse::new(status, &Headers::new(&[]));
let response = |status| {
let resp = OutgoingResponse::new(Fields::new());
resp.set_status_code(status).expect("should have set status code");
resp
};
match result {
Ok(()) => ResponseOutparam::set(response_out, Ok(response(200))),
Err(err) => {
let resp = response(500);
let body = resp.write().expect("response body was already taken");
let body = resp.body().unwrap();
ResponseOutparam::set(response_out, Ok(resp));
outgoing_body(body, err.into_bytes()).unwrap();
}
}
}

#[cfg(feature = "define-component")]
pub fn outgoing_body(body: OutgoingBody, buffer: Vec<u8>) -> Result<(), Error> {
pub fn outgoing_body(body: OutgoingBody, buffer: Vec<u8>) -> Result<(), ErrorCode> {
struct Outgoing(Option<(OutputStream, OutgoingBody)>);

impl Drop for Outgoing {
fn drop(&mut self) {
if let Some((stream, body)) = self.0.take() {
drop(stream);
OutgoingBody::finish(body, None);
OutgoingBody::finish(body, None).expect("should have finished OutgoingBody");
}
}
}
Expand Down Expand Up @@ -101,11 +105,11 @@ pub fn outgoing_body(body: OutgoingBody, buffer: Vec<u8>) -> Result<(), Error> {
Ok(()) => {
offset += count;
}
Err(e) => return Err(Error::ProtocolError(format!("I/O error: {e}"))),
Err(e) => return Err(ErrorCode::InternalError(Some(format!("I/O error: {e}")))),
}
}
}
Err(e) => return Err(Error::ProtocolError(format!("I/O error: {e}"))),
Err(e) => return Err(ErrorCode::InternalError(Some(format!("I/O error: {e}")))),
}
}
}
Expand Down
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
41 changes: 41 additions & 0 deletions wit/deps/[email protected]/world.wit
Original file line number Diff line number Diff line change
@@ -0,0 +1,41 @@
package fermyon:[email protected];

/// The full world of a guest targeting an http-trigger
world http-trigger {
include platform;
export wasi:http/[email protected];
}

/// Like `http-trigger`, but using WASI 0.2.0-rc-2023-10-18
world http-trigger-rc20231018 {
include platform-rc20231018;
export wasi:http/[email protected];
}

/// The imports needed for a guest to run on a Spin host
world platform {
include wasi:cli/[email protected];
import wasi:http/[email protected];
import llm;
import redis;
import mqtt;
import postgres;
import mysql;
import sqlite;
import key-value;
import variables;
}

/// Like `platform`, but using WASI 0.2.0-rc-2023-10-18
world platform-rc20231018 {
include wasi:cli/[email protected];
import wasi:http/[email protected];
import llm;
import redis;
import mqtt;
import postgres;
import mysql;
import sqlite;
import key-value;
import variables;
}
12 changes: 12 additions & 0 deletions wit/deps/[email protected]/world.wit
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
package fermyon:[email protected];

/// The full world of a guest targeting an http-trigger
world http-trigger {
include platform;
export wasi:http/[email protected];
}

/// The imports needed for a guest to run on a Spin host
world platform {
include fermyon:spin/[email protected];
}
42 changes: 1 addition & 41 deletions wit/world.wit
Original file line number Diff line number Diff line change
@@ -1,41 +1 @@
package fermyon:[email protected];

/// The full world of a guest targeting an http-trigger
world http-trigger {
include platform;
export wasi:http/[email protected];
}

/// Like `http-trigger`, but using WASI 0.2.0-rc-2023-10-18
world http-trigger-rc20231018 {
include platform-rc20231018;
export wasi:http/[email protected];
}

/// The imports needed for a guest to run on a Spin host
world platform {
include wasi:cli/[email protected];
import wasi:http/[email protected];
import llm;
import redis;
import mqtt;
import postgres;
import mysql;
import sqlite;
import key-value;
import variables;
}

/// Like `platform`, but using WASI 0.2.0-rc-2023-10-18
world platform-rc20231018 {
include wasi:cli/[email protected];
import wasi:http/[email protected];
import llm;
import redis;
import mqtt;
import postgres;
import mysql;
import sqlite;
import key-value;
import variables;
}
package spin:top-level;
Loading