-
Notifications
You must be signed in to change notification settings - Fork 257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spin 3 world #2887
Spin 3 world #2887
Conversation
|
Signed-off-by: itowlson <[email protected]>
…op level Signed-off-by: itowlson <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
wit/deps/[email protected]/world.wit
Outdated
include wasi:cli/[email protected]; | ||
import wasi:http/[email protected]; | ||
import fermyon:spin/[email protected]; | ||
import fermyon:spin/[email protected]; | ||
import fermyon:spin/[email protected]; | ||
import fermyon:spin/[email protected]; | ||
import fermyon:spin/[email protected]; | ||
import fermyon:spin/[email protected]; | ||
import fermyon:spin/[email protected]; | ||
import fermyon:spin/[email protected]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One option for this might be to remove most of this and instead just have include fermyon:spin/[email protected];
perhaps? (to clearly indicate it's inheriting from a historical version with other additions to come in the future)
Signed-off-by: itowlson <[email protected]>
This is based on conversations with @tschneidereit and @alexcrichton. It's broken into two commits so we can look at (some) different approaches.
The first approach (seen in the first commit) is:
fermyon:[email protected]
stuff - worlds and interfaces - intodeps
.fermyon:[email protected]
package with worlds that reference the interfaces from the@2.0.0
package, as well as others such aswasi-http
andwasi-config
.deps
(e.g.spin:[email protected]
) and be referenced from the3.0.0
worlds. (Otherwise we continue to use the Spin 2 interfaces.)The second commit goes further, and I am not quite sure how to do this right (this was a suggestion from Alex which I really like but haven't figured out yet):
fermyon:[email protected]
worlds intodeps
. (As noted, it is proposed that there are nofermyon:[email protected]
interfaces.)This is the bit I'm not clear on. The current top-level package is a placeholder. It seems to compile, but the version is clearly wrong, and the fact that it doesn't reference anything seems super weird.This uses the namespin:top-level
(unversioned) because the package itself does nothing and should never be referenced, it is just a feeble excuse to rope in a big bag o' deps (and all those are versioned). @alexcrichton I'd value getting your eyes on this!Note this does not tackle any SDK considerations around switching worlds, but existing SDKs (and binaries) should still work because the Spin 2 interfaces remain fully supported.