fix: Use ember-fetch to avoid test failures #200
Conversation
| }); | ||
| body: JSON.stringify(data), | ||
| headers: modifiedHeaders | ||
| }).then((response) => response.json()); |
There was a problem hiding this comment.
Wouldnt we want to return the response?
There was a problem hiding this comment.
Just kidding, that does return it.
|
Also, I'd like to confirm that this PR does solve the original issue. |
|
@knownasilya thanks for tackling this! |
|
I ran into this issue too. It makes it impossible to write robust acceptance tests that cover login and took a while to debug. It would be great to get this fix merged, so that others won't hit the same issue. @knownasilya I've put up a PR that fixes the tests. @jpadilla Is that all that's preventing this PR from being merged? |
|
I just set up a fork to implement this same fix. What needs doing to get this merged? I see the PR that @tomclose put up has a conflict, but is that all? |
|
Hey y'all! Sorry for the delay here. With v3 recently out the door, would @knownasilya or anyone else want to pickup this up to move it forward? |
|
I don't currently have time to work on the tests for this but can merge in any changes into my branch to continue the work. |
|
Closed by #226. Thanks again ya'll! |
closes #187
I'm not sure how to stub fetch, and fix the tests. Any guidance is appreciated.
Maybe something like http://www.wheresrhys.co.uk/fetch-mock/ ?