Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed jquery 3 promise handling to be compatible with ember promises #187

Closed
wants to merge 1 commit into from

Conversation

pfmmfp
Copy link

@pfmmfp pfmmfp commented Jan 24, 2017

More info explained here, which has been found based on this ember issue

@jpadilla
Copy link
Contributor

I'd rather us just drop replace this with ember-network like ember-simple-auth is doing now.

@jeffhertzler
Copy link

any update on this? causing me some headaches. getting race conditions in my acceptance tests. using a fork with this proposed fix for now.

@morhook
Copy link

morhook commented Apr 24, 2017

@jeffhertzler we had some issues with the migration to ember-network. You could use a more updated version that is also patched on my fork if you want: https://github.com/morhook/ember-simple-auth-token/commits/fix_jquery_3_ember_2_10

Sorry for not having a better fix yet.

@jeffhertzler
Copy link

No problem. Yeah, your fork is what I'm using for now. Works great til there's a more permanent solution.

@jpadilla
Copy link
Contributor

@morhook would you want to give this another try? Seems like the preferred alt is ember-fetch. mainmatter/ember-simple-auth#1288

If not, anyone else can step up or I'll give it a go in a couple of days.

@alechirsch
Copy link
Contributor

Using ember-fetch seems like the right way to go, I can review a pull request for including ember-fetch.

knownasilya pushed a commit to knownasilya/ember-simple-auth-token that referenced this pull request May 18, 2017
@knownasilya
Copy link
Contributor

@alechirsch #200 although I'm not sure how to stub fetch, and fix the tests. Any guidance is appreciated.

Maybe something like http://www.wheresrhys.co.uk/fetch-mock/ ?

@jpadilla
Copy link
Contributor

Closed by #226. Thanks again everyone!

@jpadilla jpadilla closed this May 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants