-
-
Notifications
You must be signed in to change notification settings - Fork 368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
compactMode: add collapsible functionality + reog job card layout #687
Conversation
packages/ui/src/components/JobCard/Details/DetailsContent/DetailsContent.tsx
Outdated
Show resolved
Hide resolved
hey @felixmosh did you have the chance to look at this updated and comments? I really want to contribute to the main repo (have many other improvements in mind) but otherwise Id need to just fork. |
Hi, sorry I didn't managed to check it out yet, will do soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rest of the PR looks Ok to me.
Thank you.
(FYI, After this PR will be merged I will change a bit styles)
} | ||
} | ||
} | ||
export const Highlight: React.FC<HighlightProps> = ({ language, text }) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pls move this refactor to a separate PR 🙏🏽
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure! lets process this first 👍🏽
Thank you for this awsome PR. |
closes #686 |
I probably needed to check the PR locally... And the collapse expand doesn't work for me... @ivnnv can you open a new PR with the fixes for 2 issues I've mentioned? |
compact.mov