Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop python<=3.7 support #145

Closed
wants to merge 3 commits into from
Closed

drop python<=3.7 support #145

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5b45f76
drop python<=3.7 support
kloczek Jun 8, 2024
2f3a0f3
update pyproject.toml to drop python<=3.7 support
kloczek Jun 8, 2024
f28e43b
remove python 3.7 and add 3.11 and 3.12 from CI
kloczek Jun 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/CI.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
matrix:
strategy:
matrix:
python-version: ["3.7", "3.8", "3.9", "3.10"]
python-version: ["3.8", "3.9", "3.10", "3.11", "3.12"]
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
python-version: ["3.8", "3.9", "3.10", "3.11", "3.12"]
python-version: ["3.8", "3.9", "3.10", "3.11"]

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah right, let's rather have the 12 be the default "full build" version below 🙏

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about min version and 3.x for simpler maintenance?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh that would be very nice, I haven't hear of that!

name: Pytest on ${{matrix.python-version}}
runs-on: ubuntu-latest

Expand Down
4 changes: 2 additions & 2 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ readme = "readme_pypi.rst"
license = {file = "LICENSE"}
dynamic = ["version"]

requires-python = ">=3.7"
requires-python = ">=3.8"
dependencies = [
"sphinx>=3.2.0",
"beautifulsoup4>=4.8.1",
Expand All @@ -26,11 +26,11 @@ classifiers = [
"Framework :: Sphinx :: Extension",
"Programming Language :: Python :: 3",
"Programming Language :: Python :: 3 :: Only",
"Programming Language :: Python :: 3.7",
"Programming Language :: Python :: 3.8",
"Programming Language :: Python :: 3.9",
"Programming Language :: Python :: 3.10",
"Programming Language :: Python :: 3.11",
"Programming Language :: Python :: 3.12",
"Topic :: Documentation",
"Topic :: Documentation :: Sphinx",
"Topic :: Software Development :: Documentation",
Expand Down
2 changes: 1 addition & 1 deletion src/sphinx_codeautolink/extension/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,7 @@ def create_references(self, app, env):
transform.example
)
if skipped and self.warn_missing_inventory:
tops = sorted(set(s.split(".")[0] for s in skipped))
tops = sorted({s.split(".")[0] for s in skipped})
msg = (
f"Cannot locate modules: {str(tops)[1:-1]}"
"\n because of missing intersphinx or documentation entries"
Expand Down
2 changes: 1 addition & 1 deletion tests/extension/_check.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,4 +39,4 @@ def check_link_targets(root: Path) -> int:

def gather_ids(soup: BeautifulSoup) -> set:
"""Gather all HTML IDs from a given page."""
return set(tag["id"] for tag in soup.find_all(id=True))
return {tag["id"] for tag in soup.find_all(id=True)}
Loading