-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
drop python<=3.7 support #145
Conversation
According to https://endoflife.date/python python 3.7 has been EOSed almost year ago. Filter all the code over `pyupgrade --py38-plus`. Signed-off-by: Tomasz Kłoczko <[email protected]>
Signed-off-by: Tomasz Kłoczko <[email protected]>
Thank you! Please do include a changelog entry under an "unreleased" header, but the change itself looks good 👍 |
Oh, and removing 7 from the github build matrix (and adding 12) would be nice too! |
Signed-off-by: Tomasz Kłoczko <[email protected]>
Hmm .. I do not understand what exactly you want me to add 😋 |
In |
@@ -15,7 +15,7 @@ jobs: | |||
matrix: | |||
strategy: | |||
matrix: | |||
python-version: ["3.7", "3.8", "3.9", "3.10"] | |||
python-version: ["3.8", "3.9", "3.10", "3.11", "3.12"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
python-version: ["3.8", "3.9", "3.10", "3.11", "3.12"] | |
python-version: ["3.8", "3.9", "3.10", "3.11"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah right, let's rather have the 12 be the default "full build" version below 🙏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about min version and 3.x
for simpler maintenance?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh that would be very nice, I haven't hear of that!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about other checks like:
HAS_WALRUS = sys.version_info >= (3, 8) |
@@ -15,7 +15,7 @@ jobs: | |||
matrix: | |||
strategy: | |||
matrix: | |||
python-version: ["3.7", "3.8", "3.9", "3.10"] | |||
python-version: ["3.8", "3.9", "3.10", "3.11", "3.12"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about min version and 3.x
for simpler maintenance?
As this got stale, I implemented this and a bit more in #151. I'll close this one, but thanks for getting the ball rolling! |
According to https://endoflife.date/python python 3.7 has been EOSed almost year ago.
Filter all the code over
pyupgrade --py38-plus
.tox
checks passed