Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop python<=3.7 support #145

Closed
wants to merge 3 commits into from
Closed

Conversation

kloczek
Copy link

@kloczek kloczek commented Jun 8, 2024

According to https://endoflife.date/python python 3.7 has been EOSed almost year ago.
Filter all the code over pyupgrade --py38-plus.

  • Tests written and passed
  • Documentation and changelog entry written, docs build passed
  • All tox checks passed

kloczek added 2 commits June 8, 2024 08:41
According to https://endoflife.date/python python 3.7 has been
EOSed almost year ago.
Filter all the code over `pyupgrade --py38-plus`.

Signed-off-by: Tomasz Kłoczko <[email protected]>
@felix-hilden
Copy link
Owner

Thank you! Please do include a changelog entry under an "unreleased" header, but the change itself looks good 👍

@felix-hilden
Copy link
Owner

Oh, and removing 7 from the github build matrix (and adding 12) would be nice too!

@kloczek
Copy link
Author

kloczek commented Jun 9, 2024

Thank you! Please do include a changelog entry under an "unreleased" header

Hmm .. I do not understand what exactly you want me to add 😋

@felix-hilden
Copy link
Owner

In docs/src/release_notes.rst, let's add a new section called "Unreleased", under which we should note that python 3.7 support was dropped (and 12 is now official). An example here from the previous bump.

@@ -15,7 +15,7 @@ jobs:
matrix:
strategy:
matrix:
python-version: ["3.7", "3.8", "3.9", "3.10"]
python-version: ["3.8", "3.9", "3.10", "3.11", "3.12"]
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
python-version: ["3.8", "3.9", "3.10", "3.11", "3.12"]
python-version: ["3.8", "3.9", "3.10", "3.11"]

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah right, let's rather have the 12 be the default "full build" version below 🙏

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about min version and 3.x for simpler maintenance?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh that would be very nice, I haven't hear of that!

Copy link

@LecrisUT LecrisUT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about other checks like:

HAS_WALRUS = sys.version_info >= (3, 8)

@@ -15,7 +15,7 @@ jobs:
matrix:
strategy:
matrix:
python-version: ["3.7", "3.8", "3.9", "3.10"]
python-version: ["3.8", "3.9", "3.10", "3.11", "3.12"]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about min version and 3.x for simpler maintenance?

@felix-hilden
Copy link
Owner

As this got stale, I implemented this and a bit more in #151. I'll close this one, but thanks for getting the ball rolling!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants