Add cache management feature #841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felddy
force-pushed
the
improvement/cache-clean
branch
2 times, most recently
from
2fc678f to
a6ff6b5
Compare
This ensures that CONTAINER_CACHE is set before we do cache management.
felddy
force-pushed
the
improvement/cache-clean
branch
from
a6ff6b5 to
c342cd4
Compare
|
@felddy Looks good from my testing. Tested with no variable set and the variable from 1-5 and it handled it perfectly. |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
This PR adds the ability to set a maximum container cache size using the
CONTAINER_CACHE_SIZEenvironment variable. After installation of a FoundryVTT distribution, ifCONTAINER_CACHE_SIZEis set, theCONTAINER_CACHEdirectory contents (if any) will be reduced the specified number of FoundryVTT distribution archives.💭 Motivation and context
This feature was requested by @madereddy in:
A PR was also submitted:
I think this feature makes sense. I took cues from #840 but added some additional safety to the removal procedure. This is also an "opt in" feature as there are folks (me included) that do keep a large number of previous versions for testing.
Closes #830
Supersedes and closes #840
🧪 Testing
I've tested this modification on my development machine, and in continuous integration. Below are sample logs of a large cache being culled:
✅ Pre-approval checklist
to reflect the changes in this PR.