Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up CONTAINER_CACHE #840

Closed
wants to merge 1 commit into from
Closed

Conversation

madereddy
Copy link

@madereddy madereddy commented Nov 15, 2023

🗣 Description

Clean up older Foundry versions saved in CONTAINER_CACHE

💭 Motivation and context

Save space on host machine and still allow the latest version to be cached.

🧪 Testing

Built the image and deployed to DockerHub

Deployed via Docker Compose

First deployment of Image:
image

Entrypoint | 2023-11-15 19:44:34 | [�[32minfo�[0m] CONTAINER_CACHE is not empty. Proceeding to clear the folder of older versions.

Cleaned the container and redeployed using Docker Compose

image

Entrypoint | 2023-11-15 19:50:17 | [�[32minfo�[0m] CONTAINER_CACHE does not have older versions.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All new and existing tests pass.

✅ Pre-merge checklist

  • Revert dependencies to default branches.
  • Finalize version.

✅ Post-merge checklist

  • Add a tag or create a release.

Clean up older Foundry versions saved in CONTAINER_CACHE

Signed-off-by: madereddy <[email protected]>
@madereddy madereddy requested a review from felddy as a code owner November 15, 2023 19:52
@madereddy madereddy mentioned this pull request Nov 15, 2023
1 task
@madereddy madereddy marked this pull request as draft November 15, 2023 20:35
@madereddy madereddy marked this pull request as ready for review November 15, 2023 20:42
@felddy felddy mentioned this pull request Nov 17, 2023
7 tasks
@madereddy
Copy link
Author

PR #841 supercedes this one.

@madereddy madereddy closed this Nov 18, 2023
Copy link

@winlover32 winlover32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants