Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Process the prefer_ssl setting. #1917

Merged
merged 1 commit into from
Oct 20, 2017
Merged

Process the prefer_ssl setting. #1917

merged 1 commit into from
Oct 20, 2017

Conversation

bowlofeggs
Copy link
Contributor

Signed-off-by: Randy Barlow [email protected]

puiterwijk
puiterwijk approved these changes Oct 20, 2017
View reviewed changes
Copy link
Contributor

@puiterwijk puiterwijk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would personally suggest renaming this setting to avatar_enforce_ssl or something. But this patch itself looks good to me.

@bowlofeggs
Copy link
Contributor Author

Renaming the setting would unfortunately be a backwards incompatible change, so would require another X release. I agree with the suggestion though, so I've filed a ticket to remember to do this the next time we have an X release: #1921

@bowlofeggs bowlofeggs merged commit a3d16ba into fedora-infra:develop Oct 20, 2017
@bowlofeggs bowlofeggs deleted the process_prefer_ssl branch October 20, 2017 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@puiterwijk puiterwijk puiterwijk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bowlofeggs @puiterwijk