Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename the prefer_ssl setting #1921

Closed
bowlofeggs opened this issue Oct 20, 2017 · 3 comments · Fixed by #2995
Closed

Rename the prefer_ssl setting #1921

bowlofeggs opened this issue Oct 20, 2017 · 3 comments · Fixed by #2995
Assignees
@bowlofeggs
Labels
Backwards incompatible The proposed change is backwards incompatible and should wait for the next major release Refactor Issues that are a refactor to improve maintainability for Bodhi RFE Requests for Enhancement

Comments

@bowlofeggs
Copy link
Contributor

Bodhi has a prefer_ssl setting, which doesn't do what it sounds like it does at all because it's only used when libravatar_dns is True, and is only used by libravatar and not generally all of Bodhi. We should rename it to something that makes that clearer, like libravatar_prefer_tls.

This is a backwards incompatible change and should be done in an X release.
@bowlofeggs bowlofeggs added Refactor Issues that are a refactor to improve maintainability for Bodhi RFE Requests for Enhancement Backwards incompatible The proposed change is backwards incompatible and should wait for the next major release labels Oct 20, 2017
@bowlofeggs bowlofeggs mentioned this issue Oct 20, 2017
Merged
@puiterwijk
Copy link
Contributor

Well, you could make a new setting and make it override the prefer_ssl setting if that's not set?

@bowlofeggs bowlofeggs self-assigned this Feb 12, 2019
bowlofeggs added a commit to bowlofeggs/bodhi that referenced this issue Feb 12, 2019
@bowlofeggs
Rename prefer_ssl to libravatar_prefer_tls.
7e95bef 
The prefer_ssl setting is renamed to libravatar_prefer_tls by this
commit. The previous name was far too generic of a name, and
implied that it had some global impact when it only affected
libravatar.

The new setting also defaults to True instead of None, a saner
default.

fixes fedora-infra#1921

Signed-off-by: Randy Barlow <[email protected]>
@bowlofeggs bowlofeggs mentioned this issue Feb 12, 2019
Merged
bowlofeggs added a commit to bowlofeggs/bodhi that referenced this issue Mar 12, 2019
@bowlofeggs
Rename prefer_ssl to libravatar_prefer_tls.
456c3dc 
The prefer_ssl setting is renamed to libravatar_prefer_tls by this
commit. The previous name was far too generic of a name, and
implied that it had some global impact when it only affected
libravatar.

The new setting also defaults to True instead of None, a saner
default.

fixes fedora-infra#1921

Signed-off-by: Randy Barlow <[email protected]>
bowlofeggs added a commit to bowlofeggs/bodhi that referenced this issue Mar 12, 2019
@bowlofeggs
Rename prefer_ssl to libravatar_prefer_tls.
3817b07 
The prefer_ssl setting is renamed to libravatar_prefer_tls by this
commit. The previous name was far too generic of a name, and
implied that it had some global impact when it only affected
libravatar.

The new setting also defaults to True instead of None, a saner
default.

fixes fedora-infra#1921

Signed-off-by: Randy Barlow <[email protected]>
@bowlofeggs
Copy link
Contributor Author

This change is planned for inclusion in the upcoming 4.0.0 release: #3221

@bowlofeggs
Copy link
Contributor Author

Bodhi 4.0.0 beta is built and deployed to staging:

https://copr.fedorainfracloud.org/coprs/bowlofeggs/bodhi-pre-release
https://bodhi.stg.fedoraproject.org/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bowlofeggs bowlofeggs

Labels
Backwards incompatible The proposed change is backwards incompatible and should wait for the next major release Refactor Issues that are a refactor to improve maintainability for Bodhi RFE Requests for Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rename prefer_ssl to libravatar_prefer_tls. bowlofeggs/bodhi
2 participants
@bowlofeggs @puiterwijk