Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The waiver button waives only one failed test, and it does not tell the user which #2363

Closed
bowlofeggs opened this issue May 8, 2018 · 2 comments
Closed

The waiver button waives only one failed test, and it does not tell the user which #2363

bowlofeggs opened this issue May 8, 2018 · 2 comments
Assignees
@ralphbean
Labels
API Issues related to Bodhi's REST API Critical We can't go on living in this sqalor, drop everything and fix it! WebUI Issues pertaining to Bodhi's web interface
Milestone
Waiving UX

Comments

@bowlofeggs
Copy link
Contributor

The "Waive Test Results" button makes a pop up with a form with a text area and a submit button. The form does not explain itself - it doesn't tell you what you are meant to type into the box, and it also does not indicate which test you are waiving:

screenshot from 2018-05-08 14-11-28

When the form is submitted only one of the failed tests gets waived, but there is no way for the user to know that only one was waived and not all, or even which one was waived.
@bowlofeggs bowlofeggs added Critical We can't go on living in this sqalor, drop everything and fix it! API Issues related to Bodhi's REST API WebUI Issues pertaining to Bodhi's web interface labels May 8, 2018
@ralphbean ralphbean added this to the Waiving UX milestone May 9, 2018
ralphbean added a commit to ralphbean/bodhi that referenced this issue May 29, 2018
@ralphbean
Give the waive dialog more context.
a941b17 
This should fix the UI for fedora-infra#2363.

There, it claims that only one failing result is waived, but a read through the
method in `models.py` suggests that *all* unsatisfied requirements are
currently waived.
@ralphbean ralphbean mentioned this issue May 29, 2018
Merged
ralphbean added a commit to ralphbean/bodhi that referenced this issue May 30, 2018
@ralphbean
Give the waive dialog more context.
c2f7229 
This should fix the UI for fedora-infra#2363.

There, it claims that only one failing result is waived, but a read through the
method in `models.py` suggests that *all* unsatisfied requirements are
currently waived.

Signed-off-by: Ralph Bean <[email protected]>
ralphbean added a commit to ralphbean/bodhi that referenced this issue May 30, 2018
@ralphbean
Give the waive dialog more context.
08a22b6 
This should fix the UI for fedora-infra#2363.

There, it claims that only one failing result is waived, but a read through the
method in `models.py` suggests that *all* unsatisfied requirements are
currently waived.

Signed-off-by: Ralph Bean <[email protected]>
ralphbean added a commit to ralphbean/bodhi that referenced this issue Jun 4, 2018
@ralphbean
Give the waive dialog more context.
c7d11ae 
This should fix the UI for fedora-infra#2363.

There, it claims that only one failing result is waived, but a read through the
method in `models.py` suggests that *all* unsatisfied requirements are
currently waived.

Signed-off-by: Ralph Bean <[email protected]>
ralphbean added a commit to ralphbean/bodhi that referenced this issue Jun 13, 2018
@ralphbean
Give the waive dialog more context.
fae8957 
This should fix the UI in a couple places:

- fixes fedora-infra#2363
- fixes fedora-infra#2270

There, it claims that only one failing result is waived, but a read through the
method in `models.py` suggests that *all* unsatisfied requirements are
currently waived.

Signed-off-by: Ralph Bean <[email protected]>
ralphbean added a commit to ralphbean/bodhi that referenced this issue Jun 18, 2018
@ralphbean
Give the waive dialog more context.
f5c633a 
This should fix the UI in a couple places:

- fixes fedora-infra#2363
- fixes fedora-infra#2270

There, it claims that only one failing result is waived, but a read through the
method in `models.py` suggests that *all* unsatisfied requirements are
currently waived.

Signed-off-by: Ralph Bean <[email protected]>
ralphbean added a commit to ralphbean/bodhi that referenced this issue Jun 19, 2018
@ralphbean
Give the waive dialog more context.
18282cc 
This should fix the UI in a couple places:

- fixes fedora-infra#2363
- fixes fedora-infra#2270

There, it claims that only one failing result is waived, but a read through the
method in `models.py` suggests that *all* unsatisfied requirements are
currently waived.

Signed-off-by: Ralph Bean <[email protected]>
ralphbean added a commit to ralphbean/bodhi that referenced this issue Jun 19, 2018
@ralphbean
Give the waive dialog more context.
71e2e80 
This should fix the UI in a couple places:

- fixes fedora-infra#2363
- fixes fedora-infra#2270

There, it claims that only one failing result is waived, but a read through the
method in `models.py` suggests that *all* unsatisfied requirements are
currently waived.

Signed-off-by: Ralph Bean <[email protected]>
ralphbean added a commit to ralphbean/bodhi that referenced this issue Jun 20, 2018
@ralphbean
Give the waive dialog more context.
bee7116 
This should fix the UI in a couple places:

- fixes fedora-infra#2363
- fixes fedora-infra#2270

There, it claims that only one failing result is waived, but a read through the
method in `models.py` suggests that *all* unsatisfied requirements are
currently waived.

Signed-off-by: Ralph Bean <[email protected]>
@ralphbean ralphbean self-assigned this Jun 21, 2018
@mergify mergify bot closed this as completed in 4d1c284 Jul 26, 2018
@bowlofeggs
Copy link
Contributor Author

This feature is planned to be included in the upcoming 3.10.0 release: #2556.

@bowlofeggs
Copy link
Contributor Author

The fix for this issue has been deployed to Fedora's staging Bodhi instance:

https://bodhi.stg.fedoraproject.org/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ralphbean ralphbean

Labels
API Issues related to Bodhi's REST API Critical We can't go on living in this sqalor, drop everything and fix it! WebUI Issues pertaining to Bodhi's web interface
Projects
None yet
Milestone
Waiving UX
Development

No branches or pull requests
2 participants
@ralphbean @bowlofeggs