Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The waiverdb UI prompt doesn't explain what the text box is for #2270

Closed
bowlofeggs opened this issue Apr 9, 2018 · 5 comments
Closed

The waiverdb UI prompt doesn't explain what the text box is for #2270

bowlofeggs opened this issue Apr 9, 2018 · 5 comments
Labels
EasyFix These are good issues to get started with if you are new to the project WebUI Issues pertaining to Bodhi's web interface

Comments

@bowlofeggs
Copy link
Contributor

If a developer clicks on the waive button on an update, there is a pop up that has a text box and a submit button. The UI does not explain the purpose of this text box and it should. The text box is supposed to be justification for waiving the test failure.
@bowlofeggs bowlofeggs added EasyFix These are good issues to get started with if you are new to the project WebUI Issues pertaining to Bodhi's web interface labels Apr 9, 2018
@son-vyas
Copy link

son-vyas commented Jun 12, 2018 •
edited
Loading

Is this issue open,@bowlofeggs?
If it is open then I would like to give it a try.

@bowlofeggs
Copy link
Contributor Author

I believe that @ralphbean is fixing this in #2394. Is that correct Ralph? If so, can you update the commit message over there to also specify that it fixes this issue? Thanks!

@bowlofeggs bowlofeggs mentioned this issue Jun 12, 2018
Merged
ralphbean added a commit to ralphbean/bodhi that referenced this issue Jun 13, 2018
@ralphbean
Give the waive dialog more context.
fae8957 
This should fix the UI in a couple places:

- fixes fedora-infra#2363
- fixes fedora-infra#2270

There, it claims that only one failing result is waived, but a read through the
method in `models.py` suggests that *all* unsatisfied requirements are
currently waived.

Signed-off-by: Ralph Bean <[email protected]>
@ralphbean
Copy link
Contributor

Done.

ralphbean added a commit to ralphbean/bodhi that referenced this issue Jun 18, 2018
@ralphbean
Give the waive dialog more context.
f5c633a 
This should fix the UI in a couple places:

- fixes fedora-infra#2363
- fixes fedora-infra#2270

There, it claims that only one failing result is waived, but a read through the
method in `models.py` suggests that *all* unsatisfied requirements are
currently waived.

Signed-off-by: Ralph Bean <[email protected]>
ralphbean added a commit to ralphbean/bodhi that referenced this issue Jun 19, 2018
@ralphbean
Give the waive dialog more context.
18282cc 
This should fix the UI in a couple places:

- fixes fedora-infra#2363
- fixes fedora-infra#2270

There, it claims that only one failing result is waived, but a read through the
method in `models.py` suggests that *all* unsatisfied requirements are
currently waived.

Signed-off-by: Ralph Bean <[email protected]>
ralphbean added a commit to ralphbean/bodhi that referenced this issue Jun 19, 2018
@ralphbean
Give the waive dialog more context.
71e2e80 
This should fix the UI in a couple places:

- fixes fedora-infra#2363
- fixes fedora-infra#2270

There, it claims that only one failing result is waived, but a read through the
method in `models.py` suggests that *all* unsatisfied requirements are
currently waived.

Signed-off-by: Ralph Bean <[email protected]>
ralphbean added a commit to ralphbean/bodhi that referenced this issue Jun 20, 2018
@ralphbean
Give the waive dialog more context.
bee7116 
This should fix the UI in a couple places:

- fixes fedora-infra#2363
- fixes fedora-infra#2270

There, it claims that only one failing result is waived, but a read through the
method in `models.py` suggests that *all* unsatisfied requirements are
currently waived.

Signed-off-by: Ralph Bean <[email protected]>
@mergify mergify bot closed this as completed in 4d1c284 Jul 26, 2018
@bowlofeggs
Copy link
Contributor Author

This feature is planned to be included in the upcoming 3.10.0 release: #2556.

@bowlofeggs
Copy link
Contributor Author

The fix for this issue has been deployed to Fedora's staging Bodhi instance:

https://bodhi.stg.fedoraproject.org/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
EasyFix These are good issues to get started with if you are new to the project WebUI Issues pertaining to Bodhi's web interface
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ralphbean @bowlofeggs @son-vyas