Create empty topic partition list for callback if needed #407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thijsc
force-pushed
the
empty_offsets_in_callback
branch
2 times, most recently
from
85f2a78 to
69de870
Compare
benesch
reviewed
Nov 26, 2021
We've seen a case where the offsets pointer in the commit callback was null. Check for this state and pass an empty topic partiton list into the callback if it happens.
thijsc
force-pushed
the
empty_offsets_in_callback
branch
from
69de870 to
9c9a697
Compare
benesch
approved these changes
Nov 26, 2021
|
Thanks! LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've seen a case where the offsets pointer in the commit callback was null. Check for this state and pass an empty topic partiton list into the callback if it happens.
Fixes #406