Create empty topic partition list for callback if needed

We've seen a case where the offsets pointer in the commit callback was null. Check for this state and pass an empty topic partiton list into the callback if it happens.
fede1024 · Nov 25, 2021 · 85f2a78 · 85f2a78
1 parent f41af6c
commit 85f2a78
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/Cargo.lock b/Cargo.lock
diff --git a/src/consumer/base_consumer.rs b/src/consumer/base_consumer.rs
@@ -39,7 +39,11 @@ pub(crate) unsafe extern "C" fn native_commit_cb<C: ConsumerContext>(
     } else {
         Ok(())
     };
-    let tpl = TopicPartitionList::from_ptr(offsets);
+    let tpl = if offsets.is_null() {
+        TopicPartitionList::new()
+    } else {
+        TopicPartitionList::from_ptr(offsets)
+    };
     context.commit_callback(commit_error, &tpl);
 
     mem::forget(tpl); // Do not free offsets