fix: default value for target on action.yml

[nuragic]

The default value for target was still major but it has been changed to any here #99.

Docs has been fixed as well, however I'm not sure about adding new tests... it would be great to have tests in place to prevent bugs like this in the future i.e. ensure that the documented defaults are correct.

Thanks!

This is my first PR here so sorry in advance if anything is missing! 🙏

[nuragic]

Additional thought 💭

As stated in the README:

based on Semantic Versioning

any is not valid in SemVer, but we have * for that, so I guess we should replace any for *

[simoneb]

Additional thought 💭

As stated in the README:

based on Semantic Versioning

any is not valid in SemVer, but we have * for that, so I guess we should replace any for *

Yes I like this idea! @Eomm shall we include it in the v3 which is coming up? @nuragic let's create an issue for this.

Also @Eomm how do we get this fix in the current v2? We don't strictly have to if we prefer to postpone it until v3, but if we do let's do the "proper" fix by using * instead of any. Let's also consider that when dealing with submodules we're not dealing with semver, so we need to decide if * is really better than "any" in that scenario

[nuragic]

I’d say that we should land this as a patch (2.7.1) maybe, then we can discuss the idea of renaming any to * for the upcoming major (v3) in a separate issue as you suggested @simoneb. What do you think @Eomm ?

[simoneb]

If it fits into the v3 rollout plan defined by @Eomm it works for me

[Eomm]

I think it is good to release it as 2.7.1.

Let's discuss the any value in an issue 👍🏽

[simoneb]

@nuragic create an issue for any -> * please

[Eomm]

This PR fixes this issue too:

• https://github.com/nearform/techbase/pull/331

Since the default was target: major in the action.yml configuration, this check was executed:

github-action-merge-dependabot/src/action.js

Line 51 in c8f3391

if (TARGET !== targetOptions.any) {

At the end this code executes:

var semver = require("semver/functions/diff")
const expression = /from ([^\s]+) to ([^\s]+)/
const title = 'chore(deps): bump nearform/optic-release-automation-action from 2.2.0 to 2.3'
const match = expression.exec(title)
const diff = semver(match[1], match[2])

Triggering the same error you can see on the GHA logs:

Invalid Version: 2.3

https://runkit.com/embed/7mev193gln7y

[simoneb]

how does it solve the issue? won't we still have the issue if when using the action we use anything that's not any?

[simoneb]

I think the real fix needs to be done and may have to be using coerce or loose options in semver

[Eomm]

how does it solve the issue?

It solves because it turn it off the check

won't we still have the issue if when using the action we use anything that's not any?

This is correct: we can still make more solid this check accepting the target option.
I will open an issue for this.

[simoneb]

thanks @Eomm , that's the way to go