-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Manage semver-like formats #124
Comments
and it should also keep working with submodules. see #98 |
One approach is the one mentioned above by @Eomm; another approach would be to use the valid SemVer number, which is in this case We're extracting the |
yes. I think the approach is to use coerce / loose options from the semver library |
What I'm saying is that IMHO the right thing to do would be to have the valid SemVer number even in the title, e.g.
|
we can't, we're not creating those PRs, dependabot is |
Yeah of course hehe I know but there's no way to fix that by changing some config here? https://github.com/fastify/github-action-merge-dependabot/blob/main/.github/dependabot.yml |
no |
@Eomm can you do a manual release of the action? We'll have to wait until next week before publishing this action using release automation, because the current version is not capable of auto updating if we create the non-semver tags |
Yes, I have checked the Publishing... |
I'm having an issue where the action still merges a major release even if the target is set to minor. For example, React v17.0.2 to v18.0.0 still gets merged.
Example PR: https://github.com/austins/smoothnanners-web/pull/17 |
When the user set the
target
option and the dependabot's PR is like the following:(note the
2.3
version)The semver check fails.
We should be more resilient and be able to merge this PR too.
Ref #121 (comment)
The text was updated successfully, but these errors were encountered: