Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: nested swagger ref #479

Merged
merged 2 commits into from
Sep 29, 2021
Merged

fix: nested swagger ref #479

merged 2 commits into from
Sep 29, 2021

Conversation

peter-mouland
Copy link
Contributor

@peter-mouland peter-mouland commented Sep 27, 2021 •
edited
Loading

related to #478 and #472

Fixes nested + complex ref's when using the swagger spec

Checklist

@peter-mouland peter-mouland mentioned this pull request Sep 27, 2021
Closed
6 tasks
mcollina
mcollina approved these changes Sep 27, 2021
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1277431813

  • 0 of 8 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 1275068859: 0.0%
Covered Lines: 559
Relevant Lines: 559
💛 - Coveralls

@coveralls
Copy link

coveralls commented Sep 27, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 1286062413

  • 13 of 13 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 1282113267: 0.0%
Covered Lines: 561
Relevant Lines: 561
💛 - Coveralls

@peter-mouland
Copy link
Contributor Author

hey @climba03003 @Eomm
I've rebased from master to remove the conflicts, is there anything else we need to do to get the PR in?

climba03003
climba03003 requested changes Sep 29, 2021
View reviewed changes
lib/spec/swagger/index.js Outdated Show resolved Hide resolved
climba03003
climba03003 requested changes Sep 29, 2021
View reviewed changes
lib/spec/swagger/utils.js Outdated Show resolved Hide resolved
climba03003
climba03003 approved these changes Sep 29, 2021
View reviewed changes
Copy link
Member

@climba03003 climba03003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mcollina mcollina merged commit 146bfb1 into fastify:master Sep 29, 2021
@peter-mouland peter-mouland deleted the fix/swagger-ref branch September 29, 2021 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@climba03003 climba03003 climba03003 approved these changes

@mcollina mcollina mcollina approved these changes

@Eomm Eomm Awaiting requested review from Eomm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@peter-mouland @coveralls @mcollina @climba03003