fix: nested refs #478
Closed
fix: nested refs #478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peter-mouland
force-pushed
the
fix/nested-refs
branch
from
fe74f69 to
516b538
Compare
2 tasks
Eomm
reviewed
Sep 26, 2021
| if (key === '$ref') { | ||
| jsonSchema[key] = `#/definitions/${jsonSchema[key]}` | ||
| } else if (key === 'examples' && Array.isArray(jsonSchema[key]) && (jsonSchema[key].length > 1)) { | ||
| jsonSchema.examples = convertExamplesArrayToObject(jsonSchema.examples) |
There was a problem hiding this comment.
not at the moment, I'm not sure why the code is handing examples. Should it be tested, or removed?
There was a problem hiding this comment.
We landed the #472 PR
is this needed?
There was a problem hiding this comment.
I'd say, this PR is still needed as this PR takes care of both Swagger and OpenAPI, that otehr PR only takes care of OpenAPI?
Does another test need to be added for when the user does not tweak buildLocalReference, or is returning the $id now preferred?
There was a problem hiding this comment.
closed in favour of #479
peter-mouland
force-pushed
the
fix/nested-refs
branch
from
516b538 to
4de83a3
Compare
|
closed in favour of #479 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Start work towards #462
TBC:
buildLocalReference?t.equal(definitions['def-3'].properties.b.$ref, '#/definitions/schemaB'), vst.equal(definitions['def-3'].properties.b.$ref, '#/definitions/def-2')?key === 'examples'in the swagger spec?Checklist
npm run testandnpm run benchmarkand the Code of conduct