fastify-session integration

[sameer-coder]

This PR adds support for fastify-session.

PR includes:

• A new SessionManager class for fastify-session
• Tests
• Documentation update

Closes #319
Closes #376

[sameer-coder]

Tests are working fine on local. I am investigating to see why the CI is failing

[simoneb]

about the build failing, I don't know what the problem is but I would try removing the lockfile. having a lockfile which is by its nature not portable across node versions doesn't seem like a good idea. also in general we don't use lock files in repos containing packages

[airhorns]

@simoneb we had a big discussion about the lockfile here #24, I think there are good reasons for keeping it, if you look at the list of failing depfu PRs on this repo right now they're all things that might break for users or break CI without the authors understanding why.

[simoneb]

@simoneb we had a big discussion about the lockfile here #24, I think there are good reasons for keeping it, if you look at the list of failing depfu PRs on this repo right now they're all things that might break for users or break CI without the authors understanding why.

well we have this PR and we don't understand why it's failing either :)

[airhorns]

Good thing we can rule out developers using different versions of the packages dependencies as a cause then! I don't think we should randomly pull levers to see if it fixes this PR, we should look at the fail! Here's the failure message:

  ● Test suite failed to run

    test/independent-strategy-instances.test.ts:26:40 - error TS2339: Property 'get' does not exist on type 'Session'.

    26     async (request) => request.session.get('messages')
                                              ~~~
    test/independent-strategy-instances.test.ts:69:53 - error TS2339: Property 'get' does not exist on type 'Session'.
 
    69     async (request) => `messages: ${request.session.get('messages')}`
                                                           ~~~
    test/independent-strategy-instances.test.ts:112:53 - error TS2339: Property 'get' does not exist on type 'Session'.

    112     async (request) => `messages: ${request.session.get('messages')}`

My guess is that one of the changes in this PR changes the type of the request.session property to be whichever is imported last, which is probably @fastify/session, overriding the interface that used to be in place before. Those tests could be updated to cast to the right session type, or to use the new helpers being added to the session manager to access the session.

[mcollina]

amazing work!

[airhorns]

Thanks for putting all this work in, just a couple more comments

[mcollina]

lgtm

[darkgl0w]

@sameer-coder > CI currently fails due to npm lock file version conflicts

[darkgl0w]

LGTM

[zekth]

✌️

[sameer-coder]

I think this PR should be good to merge.