Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support @fastify/session out of the box #319

Closed
2 tasks done
mcollina opened this issue Sep 7, 2021 · 4 comments · Fixed by #421
Closed
2 tasks done

Support @fastify/session out of the box #319

mcollina opened this issue Sep 7, 2021 · 4 comments · Fixed by #421
Assignees
@sameer-coder
Labels
good first issue Good for newcomers

Comments

@mcollina
Copy link
Member

mcollina commented Sep 7, 2021

Prerequisites

  • I have written a descriptive issue title
  • I have searched existing issues to ensure the feature has not already been requested

🚀 Feature Proposal

As https://github.com/fastify/session became part of the org, we should list it here as one of the default session manager. I think it would just work, but it still needs tests and docs.

Motivation

No response

Example

No response
@mcollina mcollina added the good first issue Good for newcomers label Sep 7, 2021
@climba03003 climba03003 linked a pull request Oct 2, 2021 that will close this issue
@fastify/session support #352
Closed
@lokshunhung lokshunhung mentioned this issue Nov 2, 2021
Closed
4 tasks
@mcollina mcollina mentioned this issue Dec 15, 2021
Closed
2 tasks
@sameer-coder
Copy link
Contributor

I have updated the docs and now working on adding some test cases. Right now fastify-secure-session is used for building the test server and that is used in all the tests. What would be some good tests to add for testing the integration with @fastify/session. I was thinking of only adding some specific tests (maybe related to oauth strategies) instead of duplicating all the existing ones with @fastify/session.

@mcollina
Copy link
Member Author

PTAL at #352

@mcollina
Copy link
Member Author

Adding new tests is ok.

@sameer-coder sameer-coder mentioned this issue Dec 20, 2021
Merged
@ash0080

This comment has been minimized.

Sign in to view
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sameer-coder sameer-coder

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fastify-session integration sameer-coder/fastify-passport
@fastify/session support
3 participants
@mcollina @sameer-coder @ash0080