Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix linting #58

Merged
merged 3 commits into from
Jan 11, 2022
Merged

Fix linting #58

merged 3 commits into from
Jan 11, 2022

Conversation

0xvbetsun
Copy link
Contributor

Closes #56
Also, the tap library was increased to the 15th version, and tests were actualized regarding this version.
Fixed minor typo in the readme

Checklist

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@darkgl0w darkgl0w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a few nits but overall LGTM with the changes I have suggested.

.github/workflows/ci.yml Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
.github/workflows/ci.yml Show resolved Hide resolved
index.d.ts Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@Eomm Eomm merged commit 8e9c373 into fastify:master Jan 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failing lint
4 participants