fix: accept code-review suggestions

fastify · Jan 11, 2022 · c12f6b8 · c12f6b8
1 parent 6ebb3b1
commit c12f6b8
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 6 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -24,12 +24,12 @@ jobs:
         uses: actions/setup-node@v2
         with:
           node-version: ${{ matrix.node-version }}
-      - name: Start Infrastructure
-        run: |
-          docker-compose up -d
       - name: Install Dependencies
         run: |
           npm install
+      - name: Start Infrastructure
+        run: |
+          docker-compose up -d
       - name: Run Tests
         run: |
           npm test

diff --git a/index.d.ts b/index.d.ts
@@ -1,6 +1,15 @@
 
 import { FastifyPluginCallback } from 'fastify';
-import { ConsumerGlobalConfig, ConsumerTopicConfig, KafkaConsumer, Message, MetadataOptions, Producer, ProducerGlobalConfig, ProducerTopicConfig } from 'node-rdkafka';
+import { 
+    ConsumerGlobalConfig, 
+    ConsumerTopicConfig, 
+    KafkaConsumer, 
+    Message, 
+    MetadataOptions, 
+    Producer, 
+    ProducerGlobalConfig, 
+    ProducerTopicConfig 
+} from 'node-rdkafka';
 
 declare module 'fastify' {
     interface FastifyKafkaMessage extends Pick<Message, 'topic' | 'partition' | 'key'> {

diff --git a/lib/consumer.js b/lib/consumer.js
@@ -29,7 +29,6 @@ function Consumer (opts, log, next, topicConf, metadataOptions) {
 
   function onReady () {
     this._log.debug('kafka-consumer:onReady')
-
     if (!calledNext) {
       calledNext = true
       return next()

diff --git a/package.json b/package.json
@@ -34,7 +34,7 @@
     "abstract-logging": "2.0.1",
     "fastify": "^3.0.0-rc.2",
     "standard": "^16.0.1",
-    "tap": "^15.1.2",
+    "tap": "^15.1.6",
     "tsd": "^0.19.1",
     "typescript": "^4.5.4"
   },