Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update(cmake): bump libs to 0.17.2 and sync merge 0.38.1 PRs #3252

Merged
merged 9 commits into from
Jun 17, 2024

Conversation

FedeDP
Copy link
Contributor

@FedeDP FedeDP commented Jun 17, 2024

What type of PR is this?

/kind release

Any specific area of the project related to this PR?

/area build

What this PR does / why we need it:

Bumps libs to 0.17.2 for the upcoming Falco 0.38.1 patch release.
Also, cherry picks:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

update(cmake): bump libs to 0.17.2

Signed-off-by: Federico Di Pierro <[email protected]>
@FedeDP
Copy link
Contributor Author

FedeDP commented Jun 17, 2024

/milestone 0.38.1

@poiana poiana requested review from jasondellaluce and Kaizhe June 17, 2024 09:00
@poiana poiana added this to the 0.38.1 milestone Jun 17, 2024
@poiana poiana added the size/XS label Jun 17, 2024
@FedeDP
Copy link
Contributor Author

FedeDP commented Jun 17, 2024

/hold
Will also cherry pick 0.38.1 PRs.

@poiana poiana added size/L and removed size/XS labels Jun 17, 2024
@FedeDP
Copy link
Contributor Author

FedeDP commented Jun 17, 2024

/unhold

Copy link

This PR may bring feature or behavior changes in the Falco engine and may require the engine version to be bumped.

Please double check userspace/engine/falco_engine_version.h file. See versioning for FALCO_ENGINE_VERSION.

/hold

Copy link
Contributor

@LucaGuerra LucaGuerra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would change PR title and description because it does not match with the content :)

@poiana
Copy link
Contributor

poiana commented Jun 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FedeDP, jasondellaluce, leogr, LucaGuerra

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [FedeDP,LucaGuerra,jasondellaluce,leogr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@FedeDP FedeDP changed the title update(cmake): bump libs to 0.17.2 update(cmake): bump libs to 0.17.2 and sync merge 0.38.1 PRs Jun 17, 2024
@FedeDP
Copy link
Contributor Author

FedeDP commented Jun 17, 2024

Thanks Luke, you are right!

@FedeDP
Copy link
Contributor Author

FedeDP commented Jun 17, 2024

/unhold

@poiana poiana merged commit 2820cd1 into release/0.38.x Jun 17, 2024
33 checks passed
@poiana poiana deleted the libs/0.17.2 branch June 17, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

7 participants