-
Notifications
You must be signed in to change notification settings - Fork 908
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update(cmake): bump libs to 0.17.2 and sync merge 0.38.1 PRs #3252
Conversation
Signed-off-by: Federico Di Pierro <[email protected]>
/milestone 0.38.1 |
/hold |
…hen running with plugins. Signed-off-by: Federico Di Pierro <[email protected]>
Signed-off-by: Federico Di Pierro <[email protected]> Co-authored-by: Melissa Kilby <[email protected]>
…dently Signed-off-by: Melissa Kilby <[email protected]>
Signed-off-by: Melissa Kilby <[email protected]>
This reverts commit 4ef7c95. Signed-off-by: Gianmatteo Palmieri <[email protected]>
Signed-off-by: Luca Guerra <[email protected]>
Signed-off-by: Luca Guerra <[email protected]>
Signed-off-by: Gianmatteo Palmieri <[email protected]> Co-authored-by: Melissa Kilby <[email protected]>
/unhold |
This PR may bring feature or behavior changes in the Falco engine and may require the engine version to be bumped. Please double check userspace/engine/falco_engine_version.h file. See versioning for FALCO_ENGINE_VERSION. /hold |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would change PR title and description because it does not match with the content :)
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: FedeDP, jasondellaluce, leogr, LucaGuerra The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thanks Luke, you are right! |
/unhold |
What type of PR is this?
/kind release
Any specific area of the project related to this PR?
/area build
What this PR does / why we need it:
Bumps libs to 0.17.2 for the upcoming Falco 0.38.1 patch release.
Also, cherry picks:
falco_metrics::to_text
implementation when running with plugins #3230Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: