Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update(engine): allow using -p to pass a format to plugin events #3239

Merged

Conversation

LucaGuerra
Copy link
Contributor

@LucaGuerra LucaGuerra commented Jun 6, 2024

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area engine

What this PR does / why we need it:

For Falco 0.38.1 we wish to fix a rule loader error when using -pk with k8s_audit plugin enabled. However, we may still wish to let people using plugins use -p to customize the output. So, following @sboschman 's suggestion we can enable -p for all sources and keep -pc, -pk etc for syscall sources.

Which issue(s) this PR fixes:

Fixes #3237

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

update(engine): enable -p option for all sources, -pk, -pc etc only for syscall sources

Copy link

github-actions bot commented Jun 6, 2024

This PR may bring feature or behavior changes in the Falco engine and may require the engine version to be bumped.

Please double check userspace/engine/falco_engine_version.h file. See versioning for FALCO_ENGINE_VERSION.

/hold

@LucaGuerra
Copy link
Contributor Author

@falcosecurity/falco-maintainers what do you think? Is it an acceptable compromise for 0.38.1?

@leogr
Copy link
Member

leogr commented Jun 6, 2024

I need to evaluate any possible edge cases, but it seems fine after a quick look. Thanks!

Copy link
Contributor

@incertum incertum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Nice!

@poiana
Copy link
Contributor

poiana commented Jun 6, 2024

LGTM label has been added.

Git tree hash: 89edfa2908bf63bb9b4098189d89d17cfd05e28c

@incertum
Copy link
Contributor

incertum commented Jun 6, 2024

/milestone 0.38.1

@poiana poiana added this to the 0.38.1 milestone Jun 6, 2024
@LucaGuerra
Copy link
Contributor Author

/unhold

Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Jun 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FedeDP, incertum, LucaGuerra

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [FedeDP,LucaGuerra,incertum]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit b8e5e2e into falcosecurity:master Jun 11, 2024
34 of 35 checks passed
@LucaGuerra LucaGuerra deleted the update/p-option-format-plugin-events branch June 11, 2024 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Falco 0.38.0 crashes with -pc/-pk and any plugin loaded
5 participants