-
Notifications
You must be signed in to change notification settings - Fork 919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update(engine): allow using -p to pass a format to plugin events #3239
update(engine): allow using -p to pass a format to plugin events #3239
Conversation
Signed-off-by: Luca Guerra <[email protected]>
This PR may bring feature or behavior changes in the Falco engine and may require the engine version to be bumped. Please double check userspace/engine/falco_engine_version.h file. See versioning for FALCO_ENGINE_VERSION. /hold |
@falcosecurity/falco-maintainers what do you think? Is it an acceptable compromise for 0.38.1? |
I need to evaluate any possible edge cases, but it seems fine after a quick look. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
Nice!
LGTM label has been added. Git tree hash: 89edfa2908bf63bb9b4098189d89d17cfd05e28c
|
/milestone 0.38.1 |
/unhold |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: FedeDP, incertum, LucaGuerra The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
/area engine
What this PR does / why we need it:
For Falco 0.38.1 we wish to fix a rule loader error when using
-pk
with k8s_audit plugin enabled. However, we may still wish to let people using plugins use-p
to customize the output. So, following @sboschman 's suggestion we can enable-p
for all sources and keep-pc
,-pk
etc for syscall sources.Which issue(s) this PR fixes:
Fixes #3237
Special notes for your reviewer:
Does this PR introduce a user-facing change?: