Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: replace Luhn-based function jsdocs with valid numbers #995

Merged
merged 3 commits into from
May 24, 2022
Merged

docs: replace Luhn-based function jsdocs with valid numbers #995

merged 3 commits into from
May 24, 2022

Conversation

import-brain
Copy link
Member

No description provided.

@import-brain import-brain added c: docs Improvements or additions to documentation p: 1-normal Nothing urgent labels May 24, 2022
@import-brain import-brain added this to the v7 - Current Major milestone May 24, 2022
@import-brain import-brain requested a review from a team May 24, 2022 12:11
@import-brain import-brain self-assigned this May 24, 2022
@import-brain import-brain requested a review from a team as a code owner May 24, 2022 12:11
@codecov
Copy link

codecov bot commented May 24, 2022 •
edited
Loading

Codecov Report

Merging #995 (24c0e54) into main (dc5c720) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #995      +/-   ##
==========================================
- Coverage   99.67%   99.67%   -0.01%     
==========================================
  Files        2111     2111              
  Lines      225957   225957              
  Branches      979      978       -1     
==========================================
- Hits       225217   225214       -3     
- Misses        720      723       +3     
  Partials       20       20
Impacted Files Coverage Δ
src/modules/finance/index.ts 99.31% <100.00%> (-0.69%) ⬇️
src/modules/helpers/index.ts 97.89% <100.00%> (ø)

@Shinigami92 Shinigami92 enabled auto-merge (squash) May 24, 2022 13:33
@Shinigami92 Shinigami92 merged commit 9432edd into main May 24, 2022
@ST-DDT ST-DDT deleted the luhn_jsdocs branch May 24, 2022 14:44
Minozzzi pushed a commit to Minozzzi/faker that referenced this pull request Jul 19, 2022
@import-brain @Minozzzi
docs: replace Luhn-based function jsdocs with valid numbers (faker-js…
a1d8b04 
…#995)
@xDivisionByZerox xDivisionByZerox added m: finance Something is referring to the finance module m: helpers Something is referring to the helpers module labels Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shinigami92 Shinigami92 Shinigami92 approved these changes

@ST-DDT ST-DDT ST-DDT approved these changes

Assignees

@import-brain import-brain

Labels
c: docs Improvements or additions to documentation m: finance Something is referring to the finance module m: helpers Something is referring to the helpers module p: 1-normal Nothing urgent
Projects
No open projects
Faker Roadmap
Status: Done
Milestone
v7 - Current Major
Development

Successfully merging this pull request may close these issues.
4 participants
@import-brain @ST-DDT @Shinigami92 @xDivisionByZerox