Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: replace Luhn-based function jsdocs with valid numbers #995

Merged
merged 3 commits into from
May 24, 2022
Merged

docs: replace Luhn-based function jsdocs with valid numbers #995

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8ea5e37
docs: replace Luhn func jsdocs with valid nums
import-brain May 24, 2022
83175a0
Merge branch 'main' into luhn_jsdocs
ST-DDT May 24, 2022
24c0e54
Merge branch 'main' into luhn_jsdocs
Shinigami92 May 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/modules/finance/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,9 +248,9 @@ export class Finance {
* @param issuer The name of the issuer (case insensitive) or the format used to generate one.
*
* @example
* faker.finance.creditCardNumber() // '4427163488668'
* faker.finance.creditCardNumber('visa') // '4882664999003'
* faker.finance.creditCardNumber('63[7-9]#-####-####-###L') // '6375-3265-4676-6644'
* faker.finance.creditCardNumber() // '4427163488662'
* faker.finance.creditCardNumber('visa') // '4882664999007'
* faker.finance.creditCardNumber('63[7-9]#-####-####-###L') // '6375-3265-4676-6646'
*/
creditCardNumber(issuer = ''): string {
let format: string;
Expand Down
2 changes: 1 addition & 1 deletion src/modules/helpers/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ export class Helpers {
* @param symbol The symbol to replace with a digit.
*
* @example
* faker.helpers.replaceCreditCardSymbols() // '6453-4876-8626-8995-3779'
* faker.helpers.replaceCreditCardSymbols() // '6453-4876-8626-8995-3771'
* faker.helpers.replaceCreditCardSymbols('1234-[4-9]-##!!-L') // '1234-9-5298-2'
*/
replaceCreditCardSymbols(
Expand Down