-
-
Notifications
You must be signed in to change notification settings - Fork 920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(animal): add petName method #3196
Conversation
✅ Deploy Preview for fakerjs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Need maintainers' help on resolving the test failure:
I am not sure what needs to be done for this. Do I need to add any other locale than en to resolve this? |
GitHub Actions has found some problems running the preflight checks. Please make sure to:
|
This is no longer blocked, but you have to adjust the test file. |
f5a2265
to
8dc5975
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #3196 +/- ##
=======================================
Coverage 99.96% 99.96%
=======================================
Files 2804 2805 +1
Lines 216974 217025 +51
Branches 961 966 +5
=======================================
+ Hits 216902 216954 +52
+ Misses 72 71 -1
|
Thanks for your contribution. ❤️ |
To resolve #2206
Adds new method
petName
on animal module