Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pet names #2206

Closed
TheProcedural opened this issue Jun 9, 2023 · 20 comments · Fixed by #3196
Closed

Pet names #2206

TheProcedural opened this issue Jun 9, 2023 · 20 comments · Fixed by #3196
Assignees
Labels
c: feature Request for new feature good first issue Good for newcomers help wanted Extra attention is needed s: accepted Accepted feature / Confirmed bug
Milestone

Comments

@TheProcedural
Copy link

Clear and concise description of the problem

There aren't pet names

Suggested solution

Add pet names

Alternative

No response

Additional context

No response

@TheProcedural TheProcedural added c: feature Request for new feature s: pending triage Pending Triage s: waiting for user interest Waiting for more users interested in this feature labels Jun 9, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 9, 2023

Thank you for your feature proposal.

We marked it as "waiting for user interest" for now to gather some feedback from our community:

  • If you would like to see this feature be implemented, please react to the description with an up-vote (:+1:).
  • If you have a suggestion or want to point out some special cases that need to be considered, please leave a comment, so we are aware about them.

We would also like to hear about other community members' use cases for the feature to give us a better understanding of their potential implicit or explicit requirements.

We will start the implementation based on:

  • the number of votes (:+1:) and comments
  • the relevance for the ecosystem
  • availability of alternatives and workarounds
  • and the complexity of the requested feature

We do this because:

  • There are plenty of languages/countries out there and we would like to ensure that every method can cover all or almost all of them.
  • Every feature we add to faker has "costs" associated to it:
    • initial costs: design, implementation, reviews, documentation
    • running costs: awareness of the feature itself, more complex module structure, increased bundle size, more work during refactors

View more issues which are waiting for user interest

@Amanshenoy008
Copy link

i would like to work on this issue

@ST-DDT
Copy link
Member

ST-DDT commented Jun 19, 2023

i would like to work on this issue

Currently, we are still waiting on user interest here. We will notify you/everyone when this has gained enough traction.
If you are interested in this feature itself, please don't forget to upvote it.

@ST-DDT ST-DDT added this to the vFuture milestone Jun 19, 2023
@benrobinsonuk
Copy link

This would be very useful for us too!

@matthewmayer
Copy link
Contributor

faker-ruby has https://github.com/faker-ruby/faker/blob/main/lib/locales/en/dog.yml faker.creature.dog.name

@import-brain import-brain removed the s: pending triage Pending Triage label Jul 1, 2023
@derekmedrano
Copy link

coming here a year later to say yes I would love pet names

@matthewmayer
Copy link
Contributor

This now has 9 upvotes, so it's approaching the point where it gets considered for implementation :) For those who would find this useful, would you just want a generic name that would work for any kind of animal ("Coco", "Max", "Shadow")? Or might you want ones which are specific for a type of animal like cats ("Whiskers", "Mittens", "Felix") etc? (if so, which animals?)

What would the main use-cases be? Like faking a website for a vet clinic? Or a dog-walking service? Or just for fun?

@TheProcedural
Copy link
Author

This now has 9 upvotes, so it's approaching the point where it gets considered for implementation :) For those who would find this useful, would you just want a generic name that would work for any kind of animal ("Coco", "Max", "Shadow")? Or might you want ones which are specific for a type of animal like cats ("Whiskers", "Mittens", "Felix") etc? (if so, which animals?)

What would the main use-cases be? Like faking a website for a vet clinic? Or a dog-walking service? Or just for fun?

Both would be great. Being able to get generic pet names or specific names by type of animal.

@ST-DDT
Copy link
Member

ST-DDT commented Mar 11, 2024

Both would be great. Being able to get generic pet names or specific names by type of animal.

Please answer the following questions:

What would the main use-cases be? Like faking a website for a vet clinic? Or a dog-walking service? Or just for fun?

Which types of animals do you need the names for?

@hikariatama
Copy link

+1, I need pet names

@ST-DDT
Copy link
Member

ST-DDT commented Jun 27, 2024

+1, I need pet names

@hikariatama Please answer the following questions:

What would the main use-cases be? Like faking data for a vet clinic? Or a dog-walking service? Or just for fun?

Which types of animals do you need the names for?

@benrobinsonuk
Copy link

benrobinsonuk commented Jun 27, 2024 via email

@hikariatama
Copy link

+1, I need pet names

@hikariatama Please answer the following questions:

What would the main use-cases be? Like faking data for a vet clinic? Or a dog-walking service? Or just for fun?

Which types of animals do you need the names for?

I can't share the details due to NDA, but what I can share is that I need it for the mock data for one of my corporate projects

@ST-DDT
Copy link
Member

ST-DDT commented Jun 27, 2024

For your usecase, are dog names different from horse/another animal names? Are there names that could be used for all pets?

@benrobinsonuk
Copy link

benrobinsonuk commented Jun 27, 2024 via email

@matthewmayer
Copy link
Contributor

This now has 13 upvotes, and should be easy enough to implement. Suggest we start with just a generic pet name list for any kind of pet, and then if there's demand later we could add specific cat or dog names etc.

What should the method name be?

faker.animal.pet()
faker.animal.petName()
?

@ST-DDT
Copy link
Member

ST-DDT commented Oct 12, 2024

I would go for petName, because then it is easier to add catName, dogName etc. in the future.
pet isn't as clear, because it could return a pet type as well.

@xDivisionByZerox xDivisionByZerox added good first issue Good for newcomers help wanted Extra attention is needed s: accepted Accepted feature / Confirmed bug and removed s: waiting for user interest Waiting for more users interested in this feature labels Oct 12, 2024
@ST-DDT ST-DDT modified the milestones: vFuture, vAnytime Oct 12, 2024
@suyashgulati
Copy link
Contributor

Can assign to me?

I would also request @ST-DDT if you can point me to a PR where any new method on any module was added.

It will be a good starting point for me to understand what all would be required when new implementation is getting added. Basically to understand how a fully-complete PR should look like after I am done.

@xDivisionByZerox
Copy link
Member

I would also request @ST-DDT if you can point me to a PR where any new method on any module was added.

You can take a look at #3162, which is the latest new method I know about.
I highly encouraged you to have a read through our Contribution Documentation regardless.

@suyashgulati
Copy link
Contributor

Thanks @xDivisionByZerox

Yes I have gone through the docs once, also had some refactoring PRs merged previously.
Just wanted to glance on how a new implementation PR should look like.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: feature Request for new feature good first issue Good for newcomers help wanted Extra attention is needed s: accepted Accepted feature / Confirmed bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

10 participants