-
-
Notifications
You must be signed in to change notification settings - Fork 920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(locale): enhance en vehicle manufacturers #3187
refactor(locale): enhance en vehicle manufacturers #3187
Conversation
✅ Deploy Preview for fakerjs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #3187 +/- ##
==========================================
- Coverage 99.96% 99.96% -0.01%
==========================================
Files 2798 2798
Lines 227375 227380 +5
Branches 957 953 -4
==========================================
- Hits 227301 227290 -11
- Misses 74 90 +16
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not familiar with (these) manufactures.
Are these actually in use in primarily English countries?
If these are more common in specific countries, then maybe we should use a country specific locale for them instead? |
Skoda is fairly popular in UK. #12 here. The others are popular in India. https://www.detailingdevils.com/blog/top-9-automobile-brands-in-india Not sure the "motors" etc is needed in Tata Motors. Eg you'd say "Tata Nexon" not "Tata Motors Nexon" |
Though I understand that normally cars are named Tata Nexon, but TATA as standalone is a group of companies Tata Group which consists various other companies, like Tata Steel, Tata Consultancy Services etc.. |
Nice! thats a good find.
With this I agree short names should be preferable. I will make the change. |
00fb537
This resolves #3186