Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(locale): enhance en vehicle manufacturers #3187

Merged
merged 5 commits into from
Oct 17, 2024

Conversation

suyashgulati
Copy link
Contributor

This resolves #3186

@suyashgulati suyashgulati requested a review from a team as a code owner October 16, 2024 10:27
Copy link

netlify bot commented Oct 16, 2024

Deploy Preview for fakerjs ready!

Name Link
🔨 Latest commit e902de5
🔍 Latest deploy log https://app.netlify.com/sites/fakerjs/deploys/67112ce435a5df00088cc057
😎 Deploy Preview https://deploy-preview-3187.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Oct 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.96%. Comparing base (017becf) to head (e902de5).
Report is 1 commits behind head on next.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #3187      +/-   ##
==========================================
- Coverage   99.96%   99.96%   -0.01%     
==========================================
  Files        2798     2798              
  Lines      227375   227380       +5     
  Branches      957      953       -4     
==========================================
- Hits       227301   227290      -11     
- Misses         74       90      +16     
Files with missing lines Coverage Δ
src/locales/en/vehicle/manufacturer.ts 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

@ST-DDT ST-DDT changed the title refactor(vehicle): Enhancing vehicle manufacturers data for non-US manufacturers refactor(locale): enhance vehicle manufacturers data for non-US manufacturers Oct 16, 2024
Copy link
Member

@ST-DDT ST-DDT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not familiar with (these) manufactures.
Are these actually in use in primarily English countries?

@ST-DDT ST-DDT added p: 1-normal Nothing urgent c: locale Permutes locale definitions m: vehicle Something is referring to the vehicle module labels Oct 16, 2024
@ST-DDT ST-DDT added this to the vAnytime milestone Oct 16, 2024
@ST-DDT ST-DDT requested review from a team October 16, 2024 11:19
@ST-DDT
Copy link
Member

ST-DDT commented Oct 16, 2024

If these are more common in specific countries, then maybe we should use a country specific locale for them instead?

@matthewmayer
Copy link
Contributor

Skoda is fairly popular in UK. #12 here.

https://www.best-selling-cars.com/britain-uk/2023-full-year-britain-best-selling-car-brands-in-the-uk/

The others are popular in India.

https://www.detailingdevils.com/blog/top-9-automobile-brands-in-india

Not sure the "motors" etc is needed in Tata Motors.

Eg you'd say "Tata Nexon" not "Tata Motors Nexon"

@suyashgulati
Copy link
Contributor Author

Not sure the "motors" etc is needed in Tata Motors.

Eg you'd say "Tata Nexon" not "Tata Motors Nexon"

Though I understand that normally cars are named Tata Nexon, but TATA as standalone is a group of companies Tata Group which consists various other companies, like Tata Steel, Tata Consultancy Services etc..

https://en.wikipedia.org/wiki/Tata_Motors

Shinigami92
Shinigami92 previously approved these changes Oct 16, 2024
@matthewmayer
Copy link
Contributor

But if listed with a list of other manufacturers eg on a car insurance website I'd expect to just see "Tata" or "MG".

image

Also we combine the "manufacturer" and "model" to give the "vehicle" method so I think we should stick to short names.

@suyashgulati
Copy link
Contributor Author

suyashgulati commented Oct 16, 2024

But if listed with a list of other manufacturers eg on a car insurance website I'd expect to just see "Tata" or "MG".

Nice! thats a good find.

Also we combine the "manufacturer" and "model" to give the "vehicle" method so I think we should stick to short names.

With this I agree short names should be preferable. I will make the change.

@ST-DDT ST-DDT enabled auto-merge (squash) October 17, 2024 15:26
@ST-DDT ST-DDT changed the title refactor(locale): enhance vehicle manufacturers data for non-US manufacturers refactor(locale): enhance en vehicle manufacturers Oct 17, 2024
@ST-DDT ST-DDT merged commit 858f8d0 into faker-js:next Oct 17, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: locale Permutes locale definitions m: vehicle Something is referring to the vehicle module p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extension to Vehicle Manufacturers List
5 participants