Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extension to Vehicle Manufacturers List #3186

Closed
suyashgulati opened this issue Oct 16, 2024 · 1 comment · Fixed by #3187
Closed

Extension to Vehicle Manufacturers List #3186

suyashgulati opened this issue Oct 16, 2024 · 1 comment · Fixed by #3187
Assignees
@suyashgulati
Labels
c: locale Permutes locale definitions m: vehicle Something is referring to the vehicle module p: 1-normal Nothing urgent
Milestone
vAnytime

Comments

@suyashgulati
Copy link
Contributor

suyashgulati commented Oct 16, 2024 •
edited
Loading

As an Extension to Vehicle Manufacturers list over added by @matthewmayer in #2881.

Adding some more Manufacturers available in India from various geolocations: India, China, Czech to the data would be beneficial.

Examples:

Indian Manufacturers:

  • Tata Motors
  • Mahindra & Mahindra

India-Japan tie up in India:

  • Maruti Suzuki

China:

  • MG Motor

Czech:

  • Skoda

I have added a PR as well, if issue is approved, we can use that.
@suyashgulati suyashgulati mentioned this issue Oct 16, 2024
Merged
@ST-DDT ST-DDT added p: 1-normal Nothing urgent c: locale Permutes locale definitions m: vehicle Something is referring to the vehicle module labels Oct 16, 2024
@ST-DDT ST-DDT added this to the vAnytime milestone Oct 16, 2024
@ST-DDT
Copy link
Member

ST-DDT commented Oct 16, 2024

FFR: When adding/updating locale data you don't need to create a new issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@suyashgulati suyashgulati

Labels
c: locale Permutes locale definitions m: vehicle Something is referring to the vehicle module p: 1-normal Nothing urgent
Projects
None yet
Milestone
vAnytime
Development

Successfully merging a pull request may close this issue.

refactor(locale): enhance en vehicle manufacturers suyashgulati/faker
2 participants
@ST-DDT @suyashgulati