-
-
Notifications
You must be signed in to change notification settings - Fork 920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(commerce): more varied product descriptions #3174
Merged
ST-DDT
merged 3 commits into
faker-js:next
from
matthewmayer:varied-product-descriptions
Oct 16, 2024
Merged
feat(commerce): more varied product descriptions #3174
ST-DDT
merged 3 commits into
faker-js:next
from
matthewmayer:varied-product-descriptions
Oct 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix faker-js#2871 samples: ``` Sleek Chips designed with Concrete for substantial performance Kuhn and Sons's most advanced Soap technology increases better capabilities New magenta Hat with ergonomic design for worthwhile comfort Ergonomic Car made with Granite for all-day somber support New Chicken model with 28 GB RAM, 969 GB storage, and winding features Stylish Table designed to make you stand out with dark looks The Enterprise-wide dedicated groupware Chips offers reliable performance and empty design Professional-grade Pizza perfect for same training and recreational use The Jessika Ball is the latest in a series of bleak products from Hickle, Langworth and Jaskolski Innovative Chips featuring authentic technology and Rubber construction Discover the young new Shoes with an exciting mix of Fresh ingredients The sleek and gigantic Pizza comes with purple LED lighting for smart functionality Introducing the Japan-inspired Mouse, blending better style with local craftsmanship Our fish-friendly Tuna ensures meager comfort for your pets Experience the plum brilliance of our Chair, perfect for shoddy environments Savor the fluffy essence in our Cheese, designed for mediocre culinary adventures Featuring Vanadium-enhanced technology, our Shoes offers unparalleled muted performance The tan Keyboard combines Gibraltar aesthetics with Argon-based durability Our delicious-inspired Computer brings a taste of luxury to your all lifestyle Discover the lion-like agility of our Keyboard, perfect for valuable users ```
✅ Deploy Preview for fakerjs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
matthewmayer
added
p: 1-normal
Nothing urgent
m: commerce
Something is referring to the commerce module
labels
Oct 12, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #3174 +/- ##
==========================================
+ Coverage 99.96% 99.97% +0.01%
==========================================
Files 2798 2798
Lines 227367 227375 +8
Branches 955 583 -372
==========================================
+ Hits 227285 227316 +31
+ Misses 82 59 -23
|
ST-DDT
approved these changes
Oct 12, 2024
Shinigami92
approved these changes
Oct 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
c: feature
Request for new feature
m: commerce
Something is referring to the commerce module
p: 1-normal
Nothing urgent
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #2871
samples: