Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More varied product descriptions #2871

Closed
matthewmayer opened this issue May 3, 2024 · 2 comments · Fixed by #3174
Closed

More varied product descriptions #2871

matthewmayer opened this issue May 3, 2024 · 2 comments · Fixed by #3174
Labels
c: feature Request for new feature m: commerce Something is referring to the commerce module p: 1-normal Nothing urgent s: waiting for user interest Waiting for more users interested in this feature

Comments

@matthewmayer
Copy link
Contributor

Clear and concise description of the problem

There are only 12 possible product descriptions in faker.commerce.productDescription() in en

Suggested solution

Similar to how we handled faker.food.description(), switch to using fake() over arrayElement() and sprinkle some additional placeholders like {{color.human}}, {{word.adjective}} in the descriptions for additional variety.

This would be backwards compatible with existing definitions in other locales, since fake patterns can just be static strings.

Alternative

No response

Additional context

No response
@matthewmayer matthewmayer added c: feature Request for new feature s: pending triage Pending Triage s: waiting for user interest Waiting for more users interested in this feature labels May 3, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 3, 2024

Thank you for your feature proposal.

We marked it as "waiting for user interest" for now to gather some feedback from our community:

  • If you would like to see this feature be implemented, please react to the description with an up-vote (:+1:).
  • If you have a suggestion or want to point out some special cases that need to be considered, please leave a comment, so we are aware about them.

We would also like to hear about other community members' use cases for the feature to give us a better understanding of their potential implicit or explicit requirements.

We will start the implementation based on:

  • the number of votes (:+1:) and comments
  • the relevance for the ecosystem
  • availability of alternatives and workarounds
  • and the complexity of the requested feature

We do this because:

  • There are plenty of languages/countries out there and we would like to ensure that every method can cover all or almost all of them.
  • Every feature we add to faker has "costs" associated to it:
    • initial costs: design, implementation, reviews, documentation
    • running costs: awareness of the feature itself, more complex module structure, increased bundle size, more work during refactors

View more issues which are waiting for user interest

@matthewmayer matthewmayer added the m: commerce Something is referring to the commerce module label May 3, 2024
@ST-DDT
Copy link
Member

ST-DDT commented May 3, 2024

@matthewmayer Please don't forget to upvote your own feature requests.

@ST-DDT ST-DDT added the p: 1-normal Nothing urgent label May 3, 2024
@xDivisionByZerox xDivisionByZerox removed the s: pending triage Pending Triage label May 3, 2024
matthewmayer added a commit to matthewmayer/faker that referenced this issue Oct 12, 2024
@matthewmayer
feat(commerce): more varied product descriptions
6c15cde 
fix faker-js#2871

samples:
```
Sleek Chips designed with Concrete for substantial performance
Kuhn and Sons's most advanced Soap technology increases better capabilities
New magenta Hat with ergonomic design for worthwhile comfort
Ergonomic Car made with Granite for all-day somber support
New Chicken model with 28 GB RAM, 969 GB storage, and winding features
Stylish Table designed to make you stand out with dark looks
The Enterprise-wide dedicated groupware Chips offers reliable performance and empty design
Professional-grade Pizza perfect for same training and recreational use
The Jessika Ball is the latest in a series of bleak products from Hickle, Langworth and Jaskolski
Innovative Chips featuring authentic technology and Rubber construction
Discover the young new Shoes with an exciting mix of Fresh ingredients
The sleek and gigantic Pizza comes with purple LED lighting for smart functionality
Introducing the Japan-inspired Mouse, blending better style with local craftsmanship
Our fish-friendly Tuna ensures meager comfort for your pets
Experience the plum brilliance of our Chair, perfect for shoddy environments
Savor the fluffy essence in our Cheese, designed for mediocre culinary adventures
Featuring Vanadium-enhanced technology, our Shoes offers unparalleled muted performance
The tan Keyboard combines Gibraltar aesthetics with Argon-based durability
Our delicious-inspired Computer brings a taste of luxury to your all lifestyle
Discover the lion-like agility of our Keyboard, perfect for valuable users
```
@matthewmayer matthewmayer mentioned this issue Oct 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: feature Request for new feature m: commerce Something is referring to the commerce module p: 1-normal Nothing urgent s: waiting for user interest Waiting for more users interested in this feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(commerce): more varied product descriptions matthewmayer/faker
3 participants
@matthewmayer @ST-DDT @xDivisionByZerox