-
-
Notifications
You must be signed in to change notification settings - Fork 925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(locale): add en_HK locale #2083
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## next #2083 +/- ##
==========================================
- Coverage 99.59% 99.59% -0.01%
==========================================
Files 2541 2567 +26
Lines 242800 243322 +522
Branches 1249 1246 -3
==========================================
+ Hits 241827 242325 +498
- Misses 946 970 +24
Partials 27 27
|
Note to self: Update migration guide to use post codes: #2004 (comment) once this is merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
already give my approval, but looks like I need to re-approve again later
My original intention was to do that in a separate PR, but this works as well. Thanks for your help! 👍 |
Adds a locale for English (Hong Kong)
A few points of note: