Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(locale): en_HK last_name_patterns should be last_name_pattern #2154

Merged
merged 2 commits into from
May 24, 2023
Merged

fix(locale): en_HK last_name_patterns should be last_name_pattern #2154

merged 2 commits into from
May 24, 2023

Conversation

matthewmayer
Copy link
Contributor

conflict of #2083 and #2059

@matthewmayer matthewmayer requested a review from a team as a code owner May 13, 2023 09:52
@matthewmayer matthewmayer self-assigned this May 13, 2023
@matthewmayer matthewmayer added p: 1-normal Nothing urgent c: locale Permutes locale definitions m: person Something is referring to the person module labels May 13, 2023
@matthewmayer matthewmayer changed the title fix(locale): en_HK last_name_patterns.ts should be last_name_pattern fix(locale): en_HK last_name_patterns should be last_name_pattern May 13, 2023
@codecov
Copy link

codecov bot commented May 13, 2023 •
edited
Loading

Codecov Report

Merging #2154 (bc43bd2) into next (1953c34) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head bc43bd2 differs from pull request most recent head ed54ffc. Consider uploading reports for the commit ed54ffc to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##             next    #2154   +/-   ##
=======================================
  Coverage   99.58%   99.59%           
=======================================
  Files        2607     2607           
  Lines      244977   244977           
  Branches     1141     1144    +3     
=======================================
+ Hits       243966   243978   +12     
+ Misses        984      972   -12     
  Partials       27       27
Impacted Files Coverage Δ
src/locales/en_HK/person/last_name_pattern.ts 100.00% <ø> (ø)
src/locales/en_HK/person/index.ts 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

@ST-DDT ST-DDT enabled auto-merge (squash) May 24, 2023 20:44
@ST-DDT ST-DDT merged commit 03cc391 into faker-js:next May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xDivisionByZerox xDivisionByZerox xDivisionByZerox approved these changes

@import-brain import-brain import-brain approved these changes

@ST-DDT ST-DDT ST-DDT approved these changes

Assignees

@matthewmayer matthewmayer

Labels
c: locale Permutes locale definitions m: person Something is referring to the person module p: 1-normal Nothing urgent
Projects
No open projects
Faker Roadmap
Status: Done
Milestone
v8.x
Development

Successfully merging this pull request may close these issues.
4 participants
@matthewmayer @ST-DDT @import-brain @xDivisionByZerox