Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(color): fix color rgb docs #1958

Merged
merged 4 commits into from
Mar 23, 2023
Merged

docs(color): fix color rgb docs #1958

merged 4 commits into from
Mar 23, 2023

Conversation

Shinigami92
Copy link
Member

close #1957

@Shinigami92 Shinigami92 added the c: docs Improvements or additions to documentation label Mar 21, 2023
@Shinigami92 Shinigami92 requested a review from a team as a code owner March 21, 2023 15:11
@Shinigami92 Shinigami92 self-assigned this Mar 21, 2023
@Shinigami92 Shinigami92 added m: color Something is referring to the color module p: 1-normal Nothing urgent labels Mar 21, 2023
@codecov
Copy link

codecov bot commented Mar 21, 2023

Codecov Report

Merging #1958 (4d299cf) into next (8076bb0) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #1958      +/-   ##
==========================================
- Coverage   99.63%   99.62%   -0.01%     
==========================================
  Files        2384     2384              
  Lines      238991   238991              
  Branches     1231     1227       -4     
==========================================
- Hits       238125   238104      -21     
- Misses        844      865      +21     
  Partials       22       22              
Impacted Files Coverage Δ
src/modules/color/index.ts 99.79% <100.00%> (ø)

... and 1 file with indirect coverage changes

src/modules/color/index.ts Outdated Show resolved Hide resolved
src/modules/color/index.ts Outdated Show resolved Hide resolved
@Shinigami92 Shinigami92 requested review from matthewmayer, ST-DDT and a team March 22, 2023 18:36
@ST-DDT ST-DDT added the s: accepted Accepted feature / Confirmed bug label Mar 22, 2023
@ST-DDT ST-DDT requested review from a team March 22, 2023 19:22
src/modules/color/index.ts Show resolved Hide resolved
src/modules/color/index.ts Show resolved Hide resolved
@Shinigami92 Shinigami92 dismissed matthewmayer’s stale review March 23, 2023 08:16

The suggestions are not blocking, but suggestions...

@ST-DDT ST-DDT enabled auto-merge (squash) March 23, 2023 12:52
@ST-DDT ST-DDT merged commit 5f3df23 into next Mar 23, 2023
@ST-DDT ST-DDT deleted the 1957-fix-color-rgb-docs branch March 23, 2023 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: docs Improvements or additions to documentation m: color Something is referring to the color module p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

docs are confusing about default parameters of faker.color.rgb
4 participants