-
-
Notifications
You must be signed in to change notification settings - Fork 923
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: unwrap nested named union and literal types #1965
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ST-DDT
added
c: docs
Improvements or additions to documentation
p: 1-normal
Nothing urgent
c: infra
Changes to our infrastructure or project setup
labels
Mar 23, 2023
ST-DDT
added
do NOT merge yet
Do not merge this PR into the target branch yet
s: needs decision
Needs team/maintainer decision
labels
Mar 23, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## next #1965 +/- ##
==========================================
- Coverage 99.62% 99.62% -0.01%
==========================================
Files 2450 2450
Lines 239748 239748
Branches 1272 1271 -1
==========================================
- Hits 238853 238846 -7
- Misses 873 880 +7
Partials 22 22 |
Perhaps there should be a |
ST-DDT
commented
Mar 23, 2023
Team Decision We will block type expansion for all |
ST-DDT
added
s: accepted
Accepted feature / Confirmed bug
and removed
s: needs decision
Needs team/maintainer decision
labels
Mar 23, 2023
ST-DDT
removed
the
do NOT merge yet
Do not merge this PR into the target branch yet
label
Mar 23, 2023
Docs-Diff: Documentation changes detected:
- Color
- cmyk
- colorByCSSColorSpace
- hsl
- hwb
- lab
- lch
- rgb
- Helpers
- unique
- Internet
- emoji
- httpStatusCode
- url
- Random
- alpha
- alphaNumeric
- String
- alpha
- alphanumeric
- hexadecimal |
Shinigami92
previously approved these changes
Mar 24, 2023
matthewmayer
approved these changes
Mar 29, 2023
Shinigami92
approved these changes
Mar 29, 2023
xDivisionByZerox
approved these changes
Mar 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
c: docs
Improvements or additions to documentation
c: infra
Changes to our infrastructure or project setup
p: 1-normal
Nothing urgent
s: accepted
Accepted feature / Confirmed bug
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created based on the requested #1958 (comment)
This has an impact on these methods:
by unwrapping these types: