refactor(location)!: rename address module #1469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shinigami92
added
p: 1-normal
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## next #1469 +/- ##
==========================================
- Coverage 99.63% 99.62% -0.01%
==========================================
Files 2165 2165
Lines 237104 237132 +28
Branches 1015 1016 +1
==========================================
+ Hits 236229 236242 +13
- Misses 854 869 +15
Partials 21 21
|
|
In e7961b0 I didn't touched the address tests, so everything was green |
This was referenced Oct 18, 2022
ST-DDT
requested changes
Oct 18, 2022
There was a problem hiding this comment.
Please delete this file:
And update the following files:
Line 440 in e0b506f
- https://github.com/faker-js/faker/blob/1344-rename-address-module-to-location/README.md?plain=1#L24
- https://github.com/faker-js/faker/blob/1344-rename-address-module-to-location/docs/index.md?plain=1#L27
- https://github.com/faker-js/faker/blob/1344-rename-address-module-to-location/src/modules/helpers/index.ts#L473
Line 97 in e0b506f
- https://github.com/faker-js/faker/blob/1344-rename-address-module-to-location/test/helpers.spec.ts#L534 +other lines
Co-authored-by: ST-DDT <[email protected]>
|
@ST-DDT Nice catches, thx 🙂 |
ST-DDT
previously approved these changes
Oct 19, 2022
import-brain
previously approved these changes
Oct 20, 2022
xDivisionByZerox
previously approved these changes
Oct 20, 2022
|
Should we update this as well? Line 440 in 79858fe |
Shinigami92
dismissed stale reviews from xDivisionByZerox, import-brain, and ST-DDT
via
cc24a01
xDivisionByZerox
approved these changes
Oct 21, 2022
ST-DDT
approved these changes
Oct 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1344