Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src/locales/*/address/street.ts is implausible #1472

Closed
ST-DDT opened this issue Oct 18, 2022 · 6 comments
Closed

src/locales/*/address/street.ts is implausible #1472

ST-DDT opened this issue Oct 18, 2022 · 6 comments
Assignees
@Shinigami92
Labels
c: locale Permutes locale definitions m: location Something is referring to the location module p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Milestone
v8.x

Comments

@ST-DDT
Copy link
Member

ST-DDT commented Oct 18, 2022 •
edited
Loading

faker/src/locales/fr/address/street.ts

Line 1 in 79858fe

export default ['{{address.street_prefix}} {{address.street_suffix}}'];

The file should either be deleted or replaced with the English one.

Note: After #1469 is merged these files will then be located under src/locales/*/location/city.ts.
@ST-DDT ST-DDT added p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug c: locale Permutes locale definitions m: location Something is referring to the location module labels Oct 18, 2022
@ST-DDT
Copy link
Member Author

ST-DDT commented Oct 18, 2022

On hold till #1469 is fixed.

@ST-DDT ST-DDT moved this to Todo in Faker Roadmap Oct 18, 2022
@ST-DDT ST-DDT added the s: on hold Blocked by something or frozen to avoid conflicts label Oct 18, 2022
@ST-DDT
Copy link
Member Author

ST-DDT commented Oct 18, 2022

faker/src/locales/fr_BE/address/street.ts

Line 4 in 79858fe

'{{address.street_prefix}} {{address.street_suffix}}',

@ST-DDT
Copy link
Member Author

ST-DDT commented Oct 18, 2022

faker/src/locales/fr_CH/address/street.ts

Line 1 in 79858fe

export default ['{{address.street_prefix}} {{address.street_suffix}}'];

@ST-DDT
Copy link
Member Author

ST-DDT commented Oct 18, 2022

faker/src/locales/pt_PT/address/street.ts

Lines 1 to 7 in 79858fe

export default [
'{{address.street_prefix}} {{person.first_name}} {{person.last_name}}',
'N#',
'N##',
'N###',
'N###-#',
];

@ST-DDT
Copy link
Member Author

ST-DDT commented Oct 18, 2022

I might have missed some files, so the other street.ts files should be checked again.

@Shinigami92 Shinigami92 removed the s: on hold Blocked by something or frozen to avoid conflicts label Oct 25, 2022
@xDivisionByZerox
Copy link
Member

Resolved by #2051.

@github-project-automation github-project-automation bot moved this from Todo to Done in Faker Roadmap May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Shinigami92 Shinigami92

Labels
c: locale Permutes locale definitions m: location Something is referring to the location module p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
No open projects
Faker Roadmap
Status: Done
Milestone
v8.x
Development

No branches or pull requests
3 participants
@ST-DDT @Shinigami92 @xDivisionByZerox