-
-
Notifications
You must be signed in to change notification settings - Fork 633
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PlotJuggler does not build with fast-CDR version 2.x.x #919
Comments
manuelValch
pushed a commit
to manuelValch/PlotJuggler
that referenced
this issue
Jan 21, 2024
Updated minimum cmake version otherwise fastcdr find package fails. As the issue is about building with fastcdr installed from eProsima reposotories I need it to work. Issues [facontidavide#861] [facontidavide#919]
manuelValch
pushed a commit
to manuelValch/PlotJuggler
that referenced
this issue
Jan 21, 2024
If this commit is applied then plotjuggler will be able to compile and run with Fast-CDR version 2.x.x from eProsima. It can compile from: - local thirdparty folder included within the repo - install of fastcdr within the machine (usually /usr/local) to do so: - Udpated files, API and namespace names Done it because I need to use plotJuggler with latest lib from eProsima and I would like this to be available for everyone. Issue: [facontidavide#919]
manuelValch
pushed a commit
to manuelValch/PlotJuggler
that referenced
this issue
Jan 25, 2024
Added missing files from Fastcdr Ci shall build. PlotJuggler build again with or without fastcdr package installed. Issue: [facontidavide#919]
facontidavide
added a commit
that referenced
this issue
Jan 26, 2024
* Update minimum cmake version Updated minimum cmake version otherwise fastcdr find package fails. As the issue is about building with fastcdr installed from eProsima reposotories I need it to work. Issues [#861] [#919] * Update Fast-CDR thirdparty If this commit is applied then plotjuggler will be able to compile and run with Fast-CDR version 2.x.x from eProsima. It can compile from: - local thirdparty folder included within the repo - install of fastcdr within the machine (usually /usr/local) to do so: - Udpated files, API and namespace names Done it because I need to use plotJuggler with latest lib from eProsima and I would like this to be available for everyone. Issue: [#919] * Fix CI, added missing files Added missing files from Fastcdr Ci shall build. PlotJuggler build again with or without fastcdr package installed. Issue: [#919] * Update CMakeLists.txt --------- Co-authored-by: manuelValch <[email protected]> Co-authored-by: Davide Faconti <[email protected]>
Your PR fixed it for the latest version, but it is broken for the current on. Unless it is fixed, I can not add your changes |
manuelValch
pushed a commit
to manuelValch/PlotJuggler
that referenced
this issue
Feb 6, 2024
If this commit is applied then plotjuggler will be able to compile and run with Fast-CDR version 2.x.x from eProsima. It can compile from: - local thirdparty folder included within the repo - install of fastcdr within the machine (usually /usr/local) to do so: - Udpated files, API and namespace names Done it because I need to use plotJuggler with latest lib from eProsima and I would like this to be available for everyone. Issue: [facontidavide#919]
manuelValch
pushed a commit
to manuelValch/PlotJuggler
that referenced
this issue
Feb 6, 2024
Added missing files from Fastcdr Ci shall build. PlotJuggler build again with or without fastcdr package installed. Issue: [facontidavide#919]
manuelValch
pushed a commit
to manuelValch/PlotJuggler
that referenced
this issue
Feb 6, 2024
Moved up findCdr or build default library so that cmake does not fail before building when fastCdr is installed on system. Added message so that user knows when fastCdr is found on its system. Issue: [facontidavide#919] Co-authored-by: manuelValch
manuelValch
pushed a commit
to manuelValch/PlotJuggler
that referenced
this issue
Feb 6, 2024
If this commit is applied then plotjuggler will be able to compile and run with Fast-CDR version 2.x.x from eProsima. It can compile from: - local thirdparty folder included within the repo - install of fastcdr within the machine (usually /usr/local) to do so: - Udpated files, API and namespace names - Udpate configure.ac to match newly updated version Done it because I need to use plotJuggler with latest lib from eProsima and I would like this to be available for everyone. Issue: [facontidavide#919]
manuelValch
pushed a commit
to manuelValch/PlotJuggler
that referenced
this issue
Feb 6, 2024
Added missing files from Fastcdr Ci shall build. PlotJuggler build again with or without fastcdr package installed. Issue: [facontidavide#919]
manuelValch
pushed a commit
to manuelValch/PlotJuggler
that referenced
this issue
Feb 6, 2024
Moved up findCdr or build default library so that cmake does not fail before building when fastCdr is installed on system. Added message so that user knows when fastCdr is found on its system. Issue: [facontidavide#919] Co-authored-by: manuelValch
manuelValch
pushed a commit
to manuelValch/PlotJuggler
that referenced
this issue
Feb 6, 2024
Moved up findCdr or build default library so that cmake does not fail before building when fastCdr is installed on system. Added message so that user knows when fastCdr is found on its system. Issue: [facontidavide#919] Co-authored-by: manuelValch
manuelValch
pushed a commit
to manuelValch/PlotJuggler
that referenced
this issue
Feb 6, 2024
Remain compatible to fastCdr version 1.1.x so that build with Ros is not broken Issue: [facontidavide#919] Co-authored-by: manuelValch
manuelValch
pushed a commit
to manuelValch/PlotJuggler
that referenced
this issue
Feb 6, 2024
If this commit is applied then plotjuggler will be able to compile and run with Fast-CDR version 2.x.x from eProsima. It can compile from: - local thirdparty folder included within the repo - install of fastcdr within the machine (usually /usr/local) to do so: - Udpated files, API and namespace names - Udpate configure.ac to match newly updated version Done it because I need to use plotJuggler with latest lib from eProsima and I would like this to be available for everyone. Issue: [facontidavide#919]
manuelValch
pushed a commit
to manuelValch/PlotJuggler
that referenced
this issue
Feb 6, 2024
Added missing files from Fastcdr Ci shall build. PlotJuggler build again with or without fastcdr package installed. Issue: [facontidavide#919]
manuelValch
pushed a commit
to manuelValch/PlotJuggler
that referenced
this issue
Feb 6, 2024
Moved up findCdr or build default library so that cmake does not fail before building when fastCdr is installed on system. Added message so that user knows when fastCdr is found on its system. Issue: [facontidavide#919] Co-authored-by: manuelValch
manuelValch
pushed a commit
to manuelValch/PlotJuggler
that referenced
this issue
Feb 6, 2024
Remain compatible to fastCdr version 1.1.x so that build with Ros is not broken Issue: [facontidavide#919] Co-authored-by: manuelValch
manuelValch
added a commit
to manuelValch/PlotJuggler
that referenced
this issue
Feb 14, 2024
If this commit is applied then fastCDR library will be build in original CMakeLists.txt file i.e ./rosx_introspection. Done that as it is a change requested in pull request. Issue: [facontidavide#919] Co-authored-by: ManuelValch <[email protected]>
manuelValch
pushed a commit
to manuelValch/PlotJuggler
that referenced
this issue
Feb 14, 2024
If this commit is applied then plotjuggler will be able to compile and run with Fast-CDR version 2.x.x from eProsima. It can compile from: - local thirdparty folder included within the repo - install of fastcdr within the machine (usually /usr/local) to do so: - Udpated files, API and namespace names - Udpate configure.ac to match newly updated version Done it because I need to use plotJuggler with latest lib from eProsima and I would like this to be available for everyone. Issue: [facontidavide#919]
manuelValch
pushed a commit
to manuelValch/PlotJuggler
that referenced
this issue
Feb 14, 2024
Added missing files from Fastcdr Ci shall build. PlotJuggler build again with or without fastcdr package installed. Issue: [facontidavide#919]
manuelValch
pushed a commit
to manuelValch/PlotJuggler
that referenced
this issue
Feb 14, 2024
Moved up findCdr or build default library so that cmake does not fail before building when fastCdr is installed on system. Added message so that user knows when fastCdr is found on its system. Issue: [facontidavide#919] Co-authored-by: manuelValch
manuelValch
pushed a commit
to manuelValch/PlotJuggler
that referenced
this issue
Feb 14, 2024
Remain compatible to fastCdr version 1.1.x so that build with Ros is not broken Issue: [facontidavide#919] Co-authored-by: manuelValch
manuelValch
added a commit
to manuelValch/PlotJuggler
that referenced
this issue
Feb 14, 2024
If this commit is applied then fastCDR library will be build in original CMakeLists.txt file i.e ./rosx_introspection. Done that as it is a change requested in pull request. Issue: [facontidavide#919] Co-authored-by: ManuelValch <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Problem description
With latest version of fast-CDR: https://github.com/eProsima/Fast-CDR installed on the dev PC plotjuggler does not build.
Mainly because eProsima updated API name, namespaces and so on.
As a Sw developer I need to be able to compile plotJuggler with latest Fast-CDR so that I can have the data visualizer plugin from eProsima.
Answer these questions (or I will ignore your issue)
Version of PlotJuggler is the latest from main (3.8.8), commit hash: 92f7389
2. Compile and try the latest version in the main branch and check if the problem persists.
Yes it does persist.
Would say this is not applicable.
Not applicable, though will test fast-DDS visualizer plugin with the demo example from eProsima
Note that I would like to contribute to the repo to help solve this issue.
The text was updated successfully, but these errors were encountered: