Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HITL - Add end episode form and error reporting #1968

Merged
merged 8 commits into from
May 21, 2024
Merged

HITL - Add end episode form and error reporting #1968

merged 8 commits into from
May 21, 2024

Conversation

0mdc
Copy link
Contributor

@0mdc 0mdc commented May 20, 2024

Motivation and Context

This changeset adds a modal dialog box for ending the episode.

It allows users to either:

  • Signal the episode as successfully completed.
  • Report a problem with the episode.
    • The episode is considered as failed in this case.
    • The user message is propagated to logs and collected data.
  • Cancel and go back to rearrange.
end_episode_form-2024-05-20_18.41.01.mp4

How it works

The modal dialog box is a state machine. It emits events to signal that the state should be changed.

For context on how the new components work, see:

Notes

Depends on:

How Has This Been Tested

Tested on multiplayer application.

Types of changes

  • [Development]

Checklist

  • My code follows the code style of this project.
  • I have updated the documentation if required.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes if required.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label May 20, 2024
aclegg3
aclegg3 approved these changes May 21, 2024
View reviewed changes
Copy link
Contributor

@aclegg3 aclegg3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0mdc 0mdc merged commit ef73aa1 into main May 21, 2024
3 of 4 checks passed
@0mdc 0mdc deleted the 0mdc/error_report branch May 21, 2024 15:58
0mdc added a commit that referenced this pull request May 23, 2024
@0mdc
HITL - Add end episode form and error reporting (#1968)
c3963a6 
* Add session management.

* Formatting changes.

* Add clarifications to episode resolution.

* Document temporary hack to check for client-side loading status.

* Add session recorder, ui events and data upload.

* Add end episode form with error reporting.
dannymcy pushed a commit to dannymcy/habitat-lab that referenced this pull request Jun 26, 2024
@0mdc @dannymcy
HITL - Add end episode form and error reporting (facebookresearch#1968)
2cd9d4f 
* Add session management.

* Formatting changes.

* Add clarifications to episode resolution.

* Document temporary hack to check for client-side loading status.

* Add session recorder, ui events and data upload.

* Add end episode form with error reporting.
dannymcy pushed a commit to dannymcy/habitat-lab that referenced this pull request Jul 8, 2024
@0mdc
HITL - Add end episode form and error reporting (facebookresearch#1968)
b94b64d 
* Add session management.

* Formatting changes.

* Add clarifications to episode resolution.

* Document temporary hack to check for client-side loading status.

* Add session recorder, ui events and data upload.

* Add end episode form with error reporting.
dannymcy pushed a commit to dannymcy/habitat-lab that referenced this pull request Jul 8, 2024
@0mdc @dannymcy
HITL - Add end episode form and error reporting (facebookresearch#1968)
decde1f 
* Add session management.

* Formatting changes.

* Add clarifications to episode resolution.

* Document temporary hack to check for client-side loading status.

* Add session recorder, ui events and data upload.

* Add end episode form with error reporting.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aclegg3 aclegg3 aclegg3 approved these changes

@jturner65 jturner65 Awaiting requested review from jturner65

@zephirefaith zephirefaith Awaiting requested review from zephirefaith

@Ram81 Ram81 Awaiting requested review from Ram81

Assignees
No one assigned
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@0mdc @aclegg3 @facebook-github-bot