Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HITL - Add buttons and modal dialog boxes. #1956

Merged
merged 1 commit into from
May 17, 2024
Merged

HITL - Add buttons and modal dialog boxes. #1956

merged 1 commit into from
May 17, 2024

Conversation

0mdc
Copy link
Contributor

@0mdc 0mdc commented May 15, 2024

Motivation and Context

This change introduces networked UI elements. A button and modal dialog boxes are added.

dialogue-2024-05-15_09.46.42.mp4

How it works

UI elements follow the immediate mode GUI pattern. They are both keyframe consumers and message producers.

How buttons work:

  1. Server creates a button named X and sends it to the client.
  2. Client receives it, renders it, and stores whether it was clicked.
  3. Client sends back X's state.
  4. Server checks whether X was clicked.

Notes

  • Dialogue boxes are simply containers of UI elements (right now only supporting buttons).
  • A UI wrapper will be created. For the sake of simplifying deltas, this will be done in a later changeset.

Related to:

How Has This Been Tested

Tested in multiplayer HITL application.

Types of changes

  • [Development]

Checklist

  • My code follows the code style of this project.
  • I have updated the documentation if required.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes if required.

@0mdc 0mdc merged commit 16fb5fb into main May 17, 2024
4 checks passed
@0mdc 0mdc deleted the 0mdc/modal_dialogues branch May 17, 2024 17:43
0mdc added a commit that referenced this pull request May 23, 2024
dannymcy pushed a commit to dannymcy/habitat-lab that referenced this pull request Jun 26, 2024
dannymcy pushed a commit to dannymcy/habitat-lab that referenced this pull request Jul 8, 2024
dannymcy pushed a commit to dannymcy/habitat-lab that referenced this pull request Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants