Mephisto 1.0 Release PR #691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Standard operations datatypes
Client io handler
Removing Supervisor, Creating Worker Pool
Asyncio Worker Pool + Operator
Async Channel API
Asyncio Agent IO refactor
TODO Cleanup
pringshia
reviewed
Mar 17, 2022
| requester_provider_type = reqs[0].provider_type | ||
| if provider_type != requester_provider_type: | ||
| print( | ||
| f"{format_loud('[WARNING]:')} Mismatch between specified provider_type " |
There was a problem hiding this comment.
format_loud makes things red right? wonder if it should be bright yellow instead. Red seems like it's better reserved for errors as opposed to general emphasis
There was a problem hiding this comment.
It is red, though we use it elsewhere for loud warnings rather than errors as well. Perhaps this is something to address elsewhere?
Add 1.0 blog post, and Upgrade Guide checklist
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should contain all of the remaining changes that set us up for 1.0 release.
So far
MephistoDBimprovements. #689package-lock.jsoneverywhere.