Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standard operations datatypes #576

Merged
merged 7 commits into from
Feb 3, 2022
Merged

Conversation

JackUrb
Copy link
Contributor

@JackUrb JackUrb commented Sep 24, 2021

Overview

As a step towards an asyncio-compatible supervisor, this change sets up some standard datatypes that the operations layer in Mephisto can use. This merges the TrackedRun and Job concepts into a singular LiveTaskRun which can track all of the operations instances relevant to a task run.

As far as the motivation goes, there is no clear way to fully remove the coupling between the different parts of the supervisor (in that different parts need to invoke functionality of each other), however I think it still makes sense to group the types of functionality into the separate abstractions. As such, each can then make calls to each other through a specified API, and we can gradually upgrade parts of that to be async.

Implementation

Creates the LiveTaskRun dataclass, which merges TrackedRun and Job, and then updates a bunch of callsites to use the new functionality.

Testing

Automated tests are passing

@JackUrb JackUrb requested a review from pringshia September 24, 2021 17:43
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 24, 2021
@JackUrb JackUrb changed the base branch from asyncio-supervisor to main December 22, 2021 18:39
@JackUrb JackUrb changed the base branch from main to asyncio-supervisor December 22, 2021 18:40
@JackUrb JackUrb merged commit 5649ecf into asyncio-supervisor Feb 3, 2022
@JackUrb JackUrb deleted the centralized-datatypes branch February 3, 2022 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants