Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: apply hover state on breadcrumb link only #241

Merged
merged 1 commit into from
Apr 20, 2022

Conversation

lex111
Copy link
Contributor

@lex111 lex111 commented Apr 20, 2022

The hover state of breadcrumb item should not be triggered when hovering over breadcrumb separator.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 20, 2022
@github-actions
Copy link

Dist CSS Diff

diff --git a/packages/core/dist/css/default/default.css b/packages/core/dist-branch/css/default/default.css
index 183319b..d53a973 100644
--- a/packages/core/dist/css/default/default.css
+++ b/packages/core/dist-branch/css/default/default.css
@@ -1735,10 +1735,6 @@ hr {
         color: var(--ifm-breadcrumb-color-active);
       }
 
-.breadcrumbs__item:not(.breadcrumbs__item--active):hover .breadcrumbs__link {
-        background: var(--ifm-breadcrumb-item-background-active);
-      }
-
 .breadcrumbs__link {
     border-radius: var(--ifm-breadcrumb-border-radius);
     color: var(--ifm-font-color-base);
@@ -1758,6 +1754,7 @@ hr {
   }
 
 .breadcrumbs__link:hover {
+      background: var(--ifm-breadcrumb-item-background-active);
       text-decoration: none;
     }
 

@github-actions
Copy link

Size Change: -620 B (0%)

Total Size: 578 kB

Filename Size Change
./packages/core/dist/css/default-dark/default-dark-rtl.css 84 kB -89 B (0%)
./packages/core/dist/css/default-dark/default-dark-rtl.min.css 59 kB -66 B (0%)
./packages/core/dist/css/default-dark/default-dark.css 84 kB -89 B (0%)
./packages/core/dist/css/default-dark/default-dark.min.css 59 kB -66 B (0%)
./packages/core/dist/css/default/default-rtl.css 81.9 kB -89 B (0%)
./packages/core/dist/css/default/default-rtl.min.css 57.9 kB -66 B (0%)
./packages/core/dist/css/default/default.css 81.9 kB -89 B (0%)
./packages/core/dist/css/default/default.min.css 57.8 kB -66 B (0%)
ℹ️ View Unchanged
Filename Size
./packages/core/dist/js/alerts.js 409 B
./packages/core/dist/js/alerts.min.js 409 B
./packages/core/dist/js/button-groups.js 267 B
./packages/core/dist/js/button-groups.min.js 267 B
./packages/core/dist/js/dropdowns.js 1.01 kB
./packages/core/dist/js/dropdowns.min.js 1.01 kB
./packages/core/dist/js/menu.js 2.4 kB
./packages/core/dist/js/menu.min.js 2.4 kB
./packages/core/dist/js/navbar.js 1.08 kB
./packages/core/dist/js/navbar.min.js 1.08 kB
./packages/core/dist/js/pills.js 270 B
./packages/core/dist/js/pills.min.js 270 B
./packages/core/dist/js/radio-behavior.js 705 B
./packages/core/dist/js/radio-behavior.min.js 705 B
./packages/core/dist/js/tabs.js 267 B
./packages/core/dist/js/tabs.min.js 267 B

compressed-size-action

@netlify
Copy link

netlify bot commented Apr 20, 2022

Deploy Preview for infima ready!

Name Link
🔨 Latest commit e42ccaf
🔍 Latest deploy log https://app.netlify.com/sites/infima/deploys/626000c44e22ca0008f4715c
😎 Deploy Preview https://deploy-preview-241--infima.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@slorber
Copy link
Collaborator

slorber commented Apr 20, 2022

👍 thanks

@slorber slorber merged commit 63c6410 into main Apr 20, 2022
@Josh-Cena Josh-Cena deleted the lex111/breadcrumbs-hover-adjust branch May 1, 2022 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants