-
-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: use SVG icon for home breadcrumb #7183
Conversation
✅ [V2]Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-7183--docusaurus-2.netlify.app/ |
packages/docusaurus-theme-classic/src/theme/DocBreadcrumbs/index.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we use the primary color so it looks slightly more like a link?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's take the house icon from the Google collection? It's more compact by size, just compare:
<svg height="24px" viewBox="0 0 24 24" width="24px" fill="currentColor"><path d="M0 0h24v24H0z" fill="none"/><path d="M10 20v-6h4v6h5v-8h3L12 3 2 12h3v8z"/></svg>
It can be confusing, since primary color applies only to the active item of the breadcrumbs. |
That one has sharp edges, though, while all the other icons in our design system look "rounder". (I noticed a few do have square edges but I think we should update them as well, considering our boxes are round-cornered.) At best we need to edit that icon so it has rounded corners as well.
Make sense |
They provided the rounded variant too https://fonts.google.com/icons?icon.query=home&icon.style=Rounded |
Ah, that's nice! |
@lex111 FYI, there's a corner where the breadcrumb gets active state but not the link. Maybe you want to take a look? |
That's the way it's meant to be, or do you have something else in mind? |
I think it should not be active when the cursor is not in that highlighted region. The background color should appear at the same instant as the text becomes green. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM 👍
Agree on that There's something weird in Infima, because even hovering the "next" arrow, the background changes color immediately |
Will be fixed in facebookincubator/infima#241 |
Thanks for fixing it and merging. Sorry that I didn't help. Was a busy week 😅 |
Motivation
I think this improves the looks of the breadcrumbs
I also gave an outlined version a quick try, but I think I still prefer the filled version 🤔
Also a wider stroke didn't really made it better for my taste 😅 . But I'm happy to change if you like it better.
Have you read the Contributing Guidelines on pull requests?
Yes